You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@omid.apache.org by ohadshacham <gi...@git.apache.org> on 2017/12/19 08:27:48 UTC
[GitHub] incubator-omid pull request #17: [OMID-83] Attributes added to Put, Get, and...
GitHub user ohadshacham opened a pull request:
https://github.com/apache/incubator-omid/pull/17
[OMID-83] Attributes added to Put, Get, and Scan are not propagated t…
…o HBase. In many cases, as in the Phoenix case, these attributes are required and should be propagated to the server side. In Phoenix for example, attributes are used to mark data as one that should propagate to the secondary index.
This commit propagates the attributes to HBase side.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ohadshacham/incubator-omid AttributesSupport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-omid/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 2bdf776bbb9bbf0e70dd49bec41239f6fcaf654c
Author: Ohad Shacham <oh...@yahoo-inc.com>
Date: 2017-12-19T08:24:26Z
[OMID-83] Attributes added to Put, Get, and Scan are not propagated to HBase. In many cases, as in the Phoenix case, these attributes are required and should be propagated to the server side. In Phoenix for example, attributes are used to mark data as one that should propagate to the secondary index.
This commit propagates the attributes to HBase side.
----
---
[GitHub] incubator-omid pull request #17: [OMID-83] Attributes added to Put, Get, and...
Posted by ohadshacham <gi...@git.apache.org>.
Github user ohadshacham closed the pull request at:
https://github.com/apache/incubator-omid/pull/17
---
[GitHub] incubator-omid pull request #17: [OMID-83] Attributes added to Put, Get, and...
Posted by ebortnikov <gi...@git.apache.org>.
Github user ebortnikov commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/17#discussion_r166402848
--- Diff: hbase-client/src/main/java/org/apache/omid/transaction/TTable.java ---
@@ -186,6 +187,14 @@ public Result get(Transaction tx, final Get get) throws IOException {
return snapshotFilter.get(this, tsget, transaction);
}
+ private void updateAttributes(OperationWithAttributes from, OperationWithAttributes to) {
--- End diff --
makes sense to call propagateAttributes()?
---