You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Igor Belakovskiy <bu...@alum.mit.edu> on 2012/01/20 20:47:21 UTC
Review Request: Need to expose OAuth2 metadata to the container
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/
-----------------------------------------------------------
Review request for shindig and Henry Saputra.
Summary
-------
Need to expose OAuth2 metadata to the container, similar to https://issues.apache.org/jira/browse/SHINDIG-1616 where we exposed Oauth 1.0 data.
Diffs
-----
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1232531
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1232531
Diff: https://reviews.apache.org/r/3571/diff
Testing
-------
Manual
Thanks,
Igor
Re: Review Request: Need to expose OAuth2 metadata to the container
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4534
-----------------------------------------------------------
Ship it!
LGTM after whitespace fixes
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
<https://reviews.apache.org/r/3571/#comment10126>
Indentation seems like it's set very high.
The shindig imports have indentation at 2 spaces.
same for OAuth2Service interface below.
- Dan
On 2012-01-20 19:47:21, Igor Belakovskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3571/
> -----------------------------------------------------------
>
> (Updated 2012-01-20 19:47:21)
>
>
> Review request for shindig and Henry Saputra.
>
>
> Summary
> -------
>
> Need to expose OAuth2 metadata to the container, similar to https://issues.apache.org/jira/browse/SHINDIG-1616 where we exposed Oauth 1.0 data.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1232531
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1232531
>
> Diff: https://reviews.apache.org/r/3571/diff
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Igor
>
>
Re: Review Request: Need to expose OAuth2 metadata to the container
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4529
-----------------------------------------------------------
Ship it!
LGTM. Applied the patch and was able to get an oAuth2Spec section back in the ModulePrefs by adding "modulePrefs.oAuth2Spec" to the fields array on the metadata request.
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
<https://reviews.apache.org/r/3571/#comment10124>
Small nit on whitespace here.
- Stanton
On 2012-01-20 19:47:21, Igor Belakovskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3571/
> -----------------------------------------------------------
>
> (Updated 2012-01-20 19:47:21)
>
>
> Review request for shindig and Henry Saputra.
>
>
> Summary
> -------
>
> Need to expose OAuth2 metadata to the container, similar to https://issues.apache.org/jira/browse/SHINDIG-1616 where we exposed Oauth 1.0 data.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1232531
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1232531
>
> Diff: https://reviews.apache.org/r/3571/diff
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Igor
>
>
Re: Review Request: Need to expose OAuth2 metadata to the container
Posted by dd...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/
-----------------------------------------------------------
(Updated June 26, 2012, 6:15 p.m.)
Review request for shindig and Henry Saputra.
Description
-------
Need to expose OAuth2 metadata to the container, similar to https://issues.apache.org/jira/browse/SHINDIG-1616 where we exposed Oauth 1.0 data.
This addresses bug SHINDIG-1616.
https://issues.apache.org/jira/browse/SHINDIG-1616
Diffs
-----
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1232531
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1232531
Diff: https://reviews.apache.org/r/3571/diff/
Testing
-------
Manual
Thanks,
Igor Belakovskiy
Re: Review Request: Need to expose OAuth2 metadata to the container
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3571/#review4541
-----------------------------------------------------------
Ship it!
Committed r1235006
Please link the Jira here in the Bugs section at the top.
Also, please close the review.
- Dan
On 2012-01-20 19:47:21, Igor Belakovskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3571/
> -----------------------------------------------------------
>
> (Updated 2012-01-20 19:47:21)
>
>
> Review request for shindig and Henry Saputra.
>
>
> Summary
> -------
>
> Need to expose OAuth2 metadata to the container, similar to https://issues.apache.org/jira/browse/SHINDIG-1616 where we exposed Oauth 1.0 data.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1232531
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1232531
>
> Diff: https://reviews.apache.org/r/3571/diff
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Igor
>
>