You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2010/07/15 03:41:09 UTC

svn commit: r964276 - /myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java

Author: lu4242
Date: Thu Jul 15 01:41:09 2010
New Revision: 964276

URL: http://svn.apache.org/viewvc?rev=964276&view=rev
Log:
MYFACES-2744 UIData.getClientId() should not append rowIndex, instead use UIData.getContainerClientId()

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java?rev=964276&r1=964275&r2=964276&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIData.java Thu Jul 15 01:41:09 2010
@@ -302,7 +302,7 @@ public class UIData extends UIComponentB
             throw new NullPointerException();
         }
         
-        final String baseClientId = super.getClientId(context);
+        final String baseClientId = getClientId(context);
 
         // searching for this component?
         boolean returnValue = baseClientId.equals(clientId);
@@ -684,6 +684,7 @@ public class UIData extends UIComponentB
         super.setValueExpression(name, binding);
     }
 
+    /*
     @Override
     public String getClientId(FacesContext context)
     {
@@ -696,11 +697,8 @@ public class UIData extends UIComponentB
 
         StringBuilder bld = __getSharedStringBuilder();
         return bld.append(clientId).append(UINamingContainer.getSeparatorChar(context)).append(rowIndex).toString();
-    }
+    }*/
 
-    /* -= Leonardo Uribe =- Temporally commented, because it is not confirmed
-     * if this will be included in jsf 2.0 rev A. Note super.getContainerClientId(context)
-     * call getClientId()
     @Override
     public String getContainerClientId(FacesContext context)
     {
@@ -715,7 +713,7 @@ public class UIData extends UIComponentB
 
         StringBuilder bld = __getSharedStringBuilder();
         return bld.append(clientId).append(UINamingContainer.getSeparatorChar(context)).append(rowIndex).toString();        
-    }*/
+    }
 
     /**
      * Modify events queued for any child components so that the UIData state will be correctly configured before the