[GitHub] [cloudstack] rafaelweingartner commented on pull request #4698: Fix npe when migrating vm with volume

[GitBox <gi...@apache.org>]

rafaelweingartner commented on pull request #4698:
URL: https://github.com/apache/cloudstack/pull/4698#issuecomment-781257832


   @abhinandanprateek this happens on KVM. 
   
   I would like to highlight one thing here. The contributor is willing to send the changes/patch to master. We (as the ACS community) can never force the contributor to do anything he/she does not want (and that is not a technical part of the contribution). We can review the code and ask for improvement/changes; we can try to convince the contributor to send the code to an already release version, but we can not say "it is a bug fix, so send it to x.y.z" (this sounds like an order). However, as the name says, it is a contribution. Therefore, it is non-paid work dedicated to ACS that somebody is providing (unless you somehow are providing this contribution by supporting the contributor). I have seen this happening in other PRs, and as a member of the PMC I would like to highlight that this is not part of the Apache Way.
   
   If somebody/some company in the community liked the changes and would like to see it in a specific branch, they can cherry-pick/back-port from master to the version branch they want.
   
   Please, it is nothing personal or anything. It is just something I noticed, and that we (as a community) should pay attention to.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org