You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/12/16 17:08:03 UTC
Re: [PR] [ISSUE #4665] Optimize and sync recent new connectors' docs (eventmesh)
pandaapo commented on code in PR #4668:
URL: https://github.com/apache/eventmesh/pull/4668#discussion_r1428862796
##########
eventmesh-connectors/eventmesh-connector-wecom/README.md:
##########
@@ -19,4 +21,10 @@ sinkConnectorConfig:
connectorName: weComSink
# Please refer to: https://developer.work.weixin.qq.com/document/path/90236
robotWebhookKey: weComRobotWebhookKey
-```
\ No newline at end of file
+```
+
+### CloudEvent Attributes
+
+When using the eventmesh-connector-wecom sinking event, you need to add the corresponding extension filed in CloudEvent:
+
+- When key=`wecomTemplateType`, value=`text`/`markdown`, indicating the text type of the event.
Review Comment:
It should be `wecomtemplatetype`.
##########
eventmesh-connectors/eventmesh-connector-dingtalk/README.md:
##########
@@ -23,4 +24,10 @@ sinkConnectorConfig:
appSecret: dingTalkAppSecret
openConversationId: dingTalkOpenConversationId
robotCode: dingTalkRobotCode
-```
\ No newline at end of file
+```
+
+### CloudEvent Attributes
+
+When using the eventmesh-connector-dingtalk sinking event, you need to add the corresponding extension filed in CloudEvent:
+
+- When key=`dingtalkTemplateType`, value=`text`/`markdown`, indicating the text type of the event.
Review Comment:
It should be `dingtalktemplatetype`. Additionally, please help add that when `dingtalktemplatetype`‘s value is `markdown`, you can set a title for the markdown text: key=`dingtalkmarkdownmessagetitle`, value=`your title`.
应该是`dingtalktemplatetype`。另外，还请帮忙加上，当`dingtalktemplatetype`的value是`markdown`时，可以为markdown文本设置标题：key=`dingtalkmarkdownmessagetitle`，value=`您的标题`。
##########
eventmesh-connectors/eventmesh-connector-dingtalk/README.md:
##########
@@ -1,13 +1,14 @@
-# eventmesh-connector-dingtalk
+# DingTalk
-## DingtalkSinkConnector：from eventmesh to dingtalk。
+## DingtalkSinkConnector: From EventMesh to DingTalk
-1. launch your eventmesh-runtime.
+1. launch your EventMesh Runtime.
2. enable sinkConnector and check `sink-config.yml`.
-3. send a message to eventmesh with the topic defined in `pubSubConfig.subject`
+3. send a message to EventMesh with the topic defined in `pubSubConfig.subject`
+
```yaml
pubSubConfig:
- # default port is 10000
+ # default port 10000
meshAddress: 127.0.0.1:10000
Review Comment:
`127.0.0.1:10000` may be optimized to `your.eventmesh.server:10000` like [this document](https://github.com/apache/eventmesh/tree/master/eventmesh-connectors/eventmesh-connector-rabbitmq#rabbitmqsinkconnector-from-eventmesh-to-rabbitmq). The same applies to several other documents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org