[jira] [Created] (BEAM-694) TriggerTester doesn't test timer firings

["Eugene Kirpichov (JIRA)" <ji...@apache.org>]

Eugene Kirpichov created BEAM-694:
-------------------------------------

             Summary: TriggerTester doesn't test timer firings
                 Key: BEAM-694
                 URL: https://issues.apache.org/jira/browse/BEAM-694
             Project: Beam
          Issue Type: Bug
            Reporter: Eugene Kirpichov


Discussion with [~tgroh]

E: Are you familiar with TriggerTester in general? I'm confused about it. Seems like it set and deletes timers, but doesn't care about them afterwards (doesn't fire them, nor even inspect when they could have fired).

T: It looks like it should
e.g. AfterWatermarkTest#testEarlyAndAtWatermark

E: I tried removing the code that sets and deletes timers in TriggerTester and the various trigger tests still pass

T: Hrm
That's worrying
Yeah, that actually makes more sense
Because fireIfShouldFire is explicitly invoked
So we don't need actual callbacks
Which is probably broken
We should advance the watermark and assert that the trigger did fire instead
(e.g. got a callback)
*i.e.

E: You mean TriggerTester is broken?

T: It doesn't actually test that we're registering the appropriate callback
so it's not so much broken as it is itself not sufficient to demonstrate proper triggering behavior
and/or proper interaction with TimerInternals



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)