[GitHub] [accumulo] keith-turner commented on a diff in pull request #3336: fixes #473 avoids scanning entire table metadata for bulk import

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3336:
URL: https://github.com/apache/accumulo/pull/3336#discussion_r1181994667


##########
core/src/main/java/org/apache/accumulo/core/util/Nulls.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.core.util;
+
+import java.util.function.Function;
+
+public class Nulls {
+  public static <T,R> R map(T object, Function<T,R> conversion) {
+    return object == null ? null : conversion.apply(object);
+  }

Review Comment:
   I created it because using optional is long and creates an object. Using the java ternary operator is also long and requires repeating the variable which is error prone. Below are a comparison of the alternatives.
   
   ```java
   Text firstSplit = Nulls.map(info.firstSplit, Text::new);
   ```
   
   ```java
   Text firstSplit = info.firstSplit == null ? null : new Text(info.firstSplit);
   ```
   
   ```java
   Text firstSplit = Optional.ofNullable(info.firstSplit).map(Text::new).orElse(null);
   ```
   
   As for the name, given the class name is Nulls I did not think the method name needed to be more descriptive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org