You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/25 02:39:03 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #5195: [INLONG-5194][Manager] Update MD5 to SHA hashing
woofyzhao opened a new pull request, #5195:
URL: https://github.com/apache/inlong/pull/5195
- Fixes #5194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5195: [INLONG-5194][Manager] Update MD5 to SHA hashing
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5195:
URL: https://github.com/apache/inlong/pull/5195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5195: [INLONG-5194][Manager] Update MD5 to SHA hashing
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5195:
URL: https://github.com/apache/inlong/pull/5195#discussion_r929423660
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/auth/impl/InlongShiroImpl.java:
##########
@@ -80,7 +80,7 @@ public WebSessionManager getWebSessionManager() {
@Override
public CredentialsMatcher getCredentialsMatcher() {
HashedCredentialsMatcher hashedCredentialsMatcher = new HashedCredentialsMatcher();
- hashedCredentialsMatcher.setHashAlgorithmName("MD5");
+ hashedCredentialsMatcher.setHashAlgorithmName("SHA-256");
Review Comment:
Please extract the `SHA-256` as a constant, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5195: [INLONG-5194][Manager] Update MD5 to SHA hashing
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5195:
URL: https://github.com/apache/inlong/pull/5195#discussion_r929423344
##########
inlong-manager/manager-common/src/test/java/org/apache/inlong/manager/common/util/SHAUtilsTest.java:
##########
@@ -20,13 +20,13 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class MD5UtilsTest {
+public class SHAUtilsTest {
@Test
public void testIsLetterOrPattern() {
Review Comment:
The method name was incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org