[GitHub] [arrow] nealrichardson commented on pull request #12826: ARROW-15260: [R] open_dataset - add file_name as column

[GitBox <gi...@apache.org>]

nealrichardson commented on PR #12826:
URL: https://github.com/apache/arrow/pull/12826#issuecomment-1092052001

   > Currently this fails with this error:
   
   If you haven't already, can you build arrow with `-DARROW_EXTRA_ERROR_CONTEXT=ON` and include the C++ traceback from the error? From the error message it sounds like it's coming from C++ not R.
   
   Re: the printing error, we'll have to handle that somehow. I wonder how many other places we assume that the schema contains all possible valid field refs; I also think that the C++ Dataset layer should have a way of handling this better than having us special case and sniff for these "augmented columns". 
   
   (Side note: `Error in 'handle_csv_read_error()'` is misleading and should be solvable; we're catching errors and inspecting for a CSV read error message and we rethrow the error if it's not that, but then shows the error coming from the error handler and not the original function. Surely there is a way to handle this, in rlang or otherwise.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org