You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org> on 2008/09/12 20:21:44 UTC
[jira] Commented: (TAPESTRY-2566) Errors in code examples of
"Securing your application with HTTPS"
[ https://issues.apache.org/jira/browse/TAPESTRY-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630644#action_12630644 ]
Howard M. Lewis Ship commented on TAPESTRY-2566:
------------------------------------------------
contributeAlias() should be static (it isn't required, but is recommended).
The additional level of generics isn't desirable, assuming that (at some point) some other AliasContribution will be contributed.
> Errors in code examples of "Securing your application with HTTPS"
> -----------------------------------------------------------------
>
> Key: TAPESTRY-2566
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2566
> Project: Tapestry
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 5.0
> Environment: n/a
> Reporter: Lutz Hühnken
> Assignee: Howard M. Lewis Ship
> Priority: Trivial
> Fix For: 5.0.15
>
>
> On the page describing "Securing your application with HTTPS" with the URL http://tapestry.apache.org/tapestry5/guide/secure.html , there are small mistakes in the code examples.
> In the section "Securing Multiple Pages", the examples refer to the method "put" and a wrong constants class
> the line : configuration.put("admin:" + TapestryConstants.SECURE_PAGE, "true");
> should be: configuration.add("admin:" + MetaDataConstants.SECURE_PAGE, "true");
> The other example shoud be changed accordingly.
> In the section "Base URL Support", the ports in the example are mixed up.
> The line: int port = secure ? 8080 : 8443;
> should be: int port = secure ? 8443 : 8080;
> as 8443 is more usual for https, and 8080 for http, for Tomcat and I believe Jetty.
> The line
> public void contributeAlias(Configuration<AliasContribution> configuration)
> could maybe be improved to
> public static void contributeAlias(final Configuration<AliasContribution<BaseURLSource>> configuration)
> since AliasContribution is a generic class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org