[GitHub] [airflow] uranusjr commented on a diff in pull request #33527: Use `NOT EXISTS` subquery instead of `tuple_not_in_condition`

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #33527:
URL: https://github.com/apache/airflow/pull/33527#discussion_r1299299945


##########
airflow/utils/sqlalchemy.py:
##########
@@ -590,7 +592,17 @@ def tuple_not_in_condition(
 
     :meta private:
     """
-    if settings.engine.dialect.name != "mssql":
+    warnings.warn(

Review Comment:
   No need to deprecate it, this has `:meta private:` so no user code should depend on it. I feel it’s fine to keep this though, it’s a mirror to `tuple_in_condition` and might be useful at some point.



##########
airflow/utils/sqlalchemy.py:
##########
@@ -590,7 +592,17 @@ def tuple_not_in_condition(
 
     :meta private:
     """
-    if settings.engine.dialect.name != "mssql":
+    warnings.warn(

Review Comment:
   No need to deprecate it, this has `:meta private:` so no user code should depend on it. I feel it’s fine to keep this though, it’s a mirror to `tuple_in_condition` and might be useful at some point.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org