You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/01 09:11:59 UTC
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5093: [KYUUBI #5088][FLINK] Add result fetch timeout for Flink engine
pan3793 commented on code in PR #5093:
URL: https://github.com/apache/kyuubi/pull/5093#discussion_r1280331816
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1319,6 +1319,14 @@ object KyuubiConf {
.intConf
.createWithDefault(1000000)
+ val ENGINE_FLINK_FETCH_TIMEOUT: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.flink.fetch.timeout")
+ .doc("Result fetch timeout. Flink would keep fetching result until " +
+ "either the max rows limit is reached or the timeout is reached.")
+ .version("1.8.0")
+ .timeConf
+ .createWithDefault(Duration.ofMinutes(5).toMillis)
Review Comment:
I think it's not a problem if we implement the incremental fetch mechanism, the client displays the reach records immediately and waits for the next batch until the server return EOF, user could cancel the stream query at any time if they don't want more results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org