You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/04 14:46:10 UTC

[GitHub] [spark] byungsoo-oh opened a new pull request #32435: [SPARK-35306][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines

byungsoo-oh opened a new pull request #32435:
URL: https://github.com/apache/spark/pull/32435


   ### What changes were proposed in this pull request?
   This PR adds benchmark results for `BLASBenchmark` created by GitHub Actions machines. 
   Benchmark result files are added for both JDK 8 (`BLASBenchmark-result.txt`) and 11 (`BLASBenchmark-jdk11-result.txt`) in `{SPARK_HOME}/mllib-local/benchmarks/`.
   
   ### Why are the changes needed?
   In [SPARK-34950](https://issues.apache.org/jira/browse/SPARK-34950), benchmark results were updated to the ones created by Github Actions machines. 
   As benchmark results for `BLASBenchmark` (added at [SPARK-33882](https://issues.apache.org/jira/browse/SPARK-33882) and [SPARK-35150](https://issues.apache.org/jira/browse/SPARK-35150)) are not currently available at the repository, this PR adds them.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   The benchmark results were obtained by running tests with GitHub Actions workflow in my forked repository. 
   You can refer to the test results and output files from the link below. 
   - https://github.com/byungsoo-oh/spark/actions/runs/809900377
   - https://github.com/byungsoo-oh/spark/actions/runs/810084610
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #32435: [SPARK-35306][MLLIB][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32435:
URL: https://github.com/apache/spark/pull/32435#issuecomment-834040182


   Thank you, @byungsoo-oh and @HyukjinKwon !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32435: [SPARK-35306][MLLIB][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32435:
URL: https://github.com/apache/spark/pull/32435#issuecomment-834005292


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32435: [SPARK-35306][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32435:
URL: https://github.com/apache/spark/pull/32435#issuecomment-832007185


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #32435: [SPARK-35306][MLLIB][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32435:
URL: https://github.com/apache/spark/pull/32435


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org