[GitHub] [airflow] maroshmka edited a comment on pull request #11793: [AIRFLOW-8664] Postgres to GCS operator - use named cursor

[GitBox <gi...@apache.org>]

maroshmka edited a comment on pull request #11793:
URL: https://github.com/apache/airflow/pull/11793#issuecomment-716864260


   hello, I amended the system tests and docs. Few notes:
   
   _1. It took quite a lot of time making it work locally._ 
   - the GCS_BUCKET variable was used on 2 places, so I changed it to be unique only on 1 place, but didn't know where's the problem
   - Also, I needed to export `GCP_PROJECT_ID`, which wasn't in the doc
   
   _2. I'm not really sure what are these tests for._ 
   I thought there will be some assert against the real GCS bucket. But as I saw (and found in doc), there is no logic in tests and all the other tests I checked contained just bunch of tasks e.g. copying a table to bq and thats it. So, did I miss something? Or are these tests just for ensuring that it can be run in actual dag ? and if yes then ok, no matter the logic (which is tested separately). These resemble e2e tests to me, but without validation. 
   
   Not sure if 1. should be solved as I'm not sure about 2. 😄  But if yes, I can fix both later - gcs_bucket name could be generated and made unique and docs could be updated to mention setting up env vars for system tests specifically.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org