You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/30 14:54:20 UTC
[jira] [Commented] (CB-10738) $safeprojectname$ in
package.windows10.appxmanifest is not overwritten by create script, throws
compile error
[ https://issues.apache.org/jira/browse/CB-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449229#comment-15449229 ]
ASF GitHub Bot commented on CB-10738:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/194
CB-10738 Use hardcoded Id attribute in Win10 manifest
Similarly to #66 this replaces faulty `Id` attribute value to hardcoded 'App' string, preventing build failure of clean cordova-windows project.
Related issue - [CB-10738](https://issues.apache.org/jira/browse/CB-10738)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows CB-10738
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #194
----
commit d44c0dd7852da72e58e9c912890ff3ad7d18f203
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-08-30T14:34:51Z
CB-10738 Use hardcoded Id attribute in Win10 manifest
----
> $safeprojectname$ in package.windows10.appxmanifest is not overwritten by create script, throws compile error
> -------------------------------------------------------------------------------------------------------------
>
> Key: CB-10738
> URL: https://issues.apache.org/jira/browse/CB-10738
> Project: Apache Cordova
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the default.)
> Components: Windows
> Affects Versions: 4.4.2
> Reporter: Ryan Willoughby
> Assignee: Jesse MacFadyen
> Labels: reproduced, triaged
> Fix For: 4.4.3
>
>
> The {{package.windows10.appxmanifest}} in the cordova-windows template project contains the string {{$safeprojectname$}} which is never overwritten by the create script. The presence of this string then triggers a compile error and must be manually overwritten.
> Reproduction:
> {{bin/create.bat ~/myproject com.package.whatever MyProject}}
> {{cd ~/myproject}}
> {{cordova/build.bat --debug --appx=uap}}
> Error output:
> {{The app manifest must be valid as per schema: Line 26, Column 18, Reason: '$safeprojectname$' violates pattern constraint of <regex_removed>. The attribute 'Id' with value '$safeprojectname$' failed to parse.}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org