You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2026/03/13 22:10:27 UTC

[PR] [cleanup] Convert 16 test classes to SharedPulsarBaseTest [pulsar]

merlimat opened a new pull request, #25318:
URL: https://github.com/apache/pulsar/pull/25318

   ## Summary
   - Convert 16 broker test classes from `ProducerConsumerBase` to `SharedPulsarBaseTest`, reusing the JVM-wide shared Pulsar cluster singleton introduced in #25311
   - Each test gets per-method namespace isolation instead of per-class broker start/stop, significantly reducing test execution time
   - Replace hardcoded topic names with `newTopicName()` for proper isolation
   
   ### Converted classes
   BatchMessageTest, BrokerServiceBundlesCacheInvalidationTest, ChecksumTest,
   ConsumedLedgersTrimTest, CurrentLedgerRolloverIfFullTest, ExclusiveProducerTest,
   KeyValueTest, MessageChecksumTest, PartitionKeyTest, PartitionKeywordCompatibilityTest,
   ResendRequestTest, ShadowReplicatorTest, ShadowTopicTest, TopicTerminationTest,
   UnAcknowledgedMessagesTimeoutTest, ZeroQueueSizeTest
   
   ## Test plan
   - [ ] All 16 converted test classes pass with `SharedPulsarBaseTest`
   - [ ] No test isolation issues from shared cluster


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [cleanup] Convert 15 test classes to SharedPulsarBaseTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25318:
URL: https://github.com/apache/pulsar/pull/25318#issuecomment-4084831368

   Issue filed at #25350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [cleanup] Convert 15 test classes to SharedPulsarBaseTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25318:
URL: https://github.com/apache/pulsar/pull/25318#issuecomment-4084815953

   ResendRequestTest became very flaky after this change. I'll file an issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [cleanup] Convert 15 test classes to SharedPulsarBaseTest [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #25318:
URL: https://github.com/apache/pulsar/pull/25318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [cleanup] Convert 15 test classes to SharedPulsarBaseTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25318:
URL: https://github.com/apache/pulsar/pull/25318#issuecomment-4085016446

   One remaining flake in TopicTerminationTest after switching to SharedPulsarBaseTest: #25351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [cleanup] Convert 16 test classes to SharedPulsarBaseTest [pulsar]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25318:
URL: https://github.com/apache/pulsar/pull/25318#issuecomment-4058279577

   @merlimat Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [cleanup] Convert 15 test classes to SharedPulsarBaseTest [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25318:
URL: https://github.com/apache/pulsar/pull/25318#issuecomment-4084992140

   Found #25343 and merged it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org