You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/05 18:17:45 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #5232: [HUDI-3800] Fixed preserve commit metadata for compaction for untouched records
nsivabalan opened a new pull request, #5232:
URL: https://github.com/apache/hudi/pull/5232
## What is the purpose of the pull request
- During compaction, updates are present in logs, where as those records that are not updated are in base files. With compaction and preserving commit metadata, we did fix the code path for records that are updated, but those from previous base files were not fixed for file names. Infact, we had this inconsistency even before adding support for preserve commit metadata. i.e. with 0.9.0, after compaction, some records will have meta fields untouched (from previous base file), but those from logs will have all meta files re-written. We are fixing that w/ this patch.
## Brief change log
- Fixing HoodieMergeHandle to fix preserve commit metadata for untouched records from previous base file.
## Verify this pull request
- Verified manually.
before fix
```
spark.sql("select _hoodie_file_name, count(*) from hudi_trips_snapshot where partitionpath = 'americas/united_states/san_francisco' group by 1").show(false)
+--------------------------------------------------------------------------+--------+
|_hoodie_file_name |count(1)|
+--------------------------------------------------------------------------+--------+
|f0a22491-f000-42ad-ad7a-8093c9dfa3ad-0_1-34-40_20220405134801234.parquet |2 |
|f0a22491-f000-42ad-ad7a-8093c9dfa3ad-0_0-164-583_20220405135013266.parquet|6 |
+--------------------------------------------------------------------------+--------+
```
after fix
```
spark.sql("select _hoodie_file_name, count(*) from hudi_trips_snapshot where partitionpath = 'americas/united_states/san_francisco' group by 1").show(false)
+--------------------------------------------------------------------------+--------+
|_hoodie_file_name |count(1)|
+--------------------------------------------------------------------------+--------+
|60ccb4d1-6eec-4290-bc57-a67a3d7cb11f-0_0-162-581_20220405135643929.parquet|8 |
+--------------------------------------------------------------------------+--------+
```
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #5232: [HUDI-3800] Fixed preserve commit metadata for compaction for untouched records
Posted by GitBox <gi...@apache.org>.
codope merged PR #5232:
URL: https://github.com/apache/hudi/pull/5232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5232: [HUDI-3800] Fixed preserve commit metadata for compaction for untouched records
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5232:
URL: https://github.com/apache/hudi/pull/5232#issuecomment-1089153290
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "611844eade3dc23bc107d2634c5f7a271ff617c2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7841",
"triggerID" : "611844eade3dc23bc107d2634c5f7a271ff617c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 611844eade3dc23bc107d2634c5f7a271ff617c2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7841)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5232: [HUDI-3800] Fixed preserve commit metadata for compaction for untouched records
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5232:
URL: https://github.com/apache/hudi/pull/5232#issuecomment-1089149526
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "611844eade3dc23bc107d2634c5f7a271ff617c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "611844eade3dc23bc107d2634c5f7a271ff617c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 611844eade3dc23bc107d2634c5f7a271ff617c2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5232: [HUDI-3800] Fixed preserve commit metadata for compaction for untouched records
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5232:
URL: https://github.com/apache/hudi/pull/5232#issuecomment-1089249550
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "611844eade3dc23bc107d2634c5f7a271ff617c2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7841",
"triggerID" : "611844eade3dc23bc107d2634c5f7a271ff617c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 611844eade3dc23bc107d2634c5f7a271ff617c2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7841)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org