You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2021/12/16 12:58:16 UTC

Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/
-----------------------------------------------------------

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4471
    https://issues.apache.org/jira/browse/ATLAS-4471


Repository: atlas


Description
-------

Added text-editor for long-description field for Glossary/Term/Category to support formatting.


Diffs
-----

  dashboardv2/public/css/scss/common.scss 5bf8b6131 
  dashboardv2/public/css/scss/override.scss 94548ffa4 
  dashboardv2/public/css/scss/style.scss 9f4482c27 
  dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv2/public/js/main.js f2ea1d816 
  dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
  dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
  dashboardv3/public/css/scss/common.scss 9310e20cb 
  dashboardv3/public/css/scss/override.scss fb3604d92 
  dashboardv3/public/css/scss/style.scss 37d5458bc 
  dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv3/public/js/main.js 97e177c70 
  dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
  dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
  dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 


Diff: https://reviews.apache.org/r/73764/diff/1/


Testing
-------

Tested against XSS attack.


Thanks,

Farhan Khan


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Farhan Khan <fa...@freestoneinfotech.com>.

> On Jan. 3, 2022, 7:19 a.m., Prasad Pawar wrote:
> >

All the review comments are addresed and the updated patch has been provided here and on JIRA.


- Farhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/#review223911
-----------------------------------------------------------


On Dec. 16, 2021, 12:58 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73764/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2021, 12:58 p.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4471
>     https://issues.apache.org/jira/browse/ATLAS-4471
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added text-editor for long-description field for Glossary/Term/Category to support formatting.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/common.scss 5bf8b6131 
>   dashboardv2/public/css/scss/override.scss 94548ffa4 
>   dashboardv2/public/css/scss/style.scss 9f4482c27 
>   dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
>   dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
>   dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
>   dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
>   dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
>   dashboardv2/public/js/main.js f2ea1d816 
>   dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
>   dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
>   dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
>   dashboardv3/public/css/scss/common.scss 9310e20cb 
>   dashboardv3/public/css/scss/override.scss fb3604d92 
>   dashboardv3/public/css/scss/style.scss 37d5458bc 
>   dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
>   dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
>   dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
>   dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
>   dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
>   dashboardv3/public/js/main.js 97e177c70 
>   dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
>   dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
>   dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 
> 
> 
> Diff: https://reviews.apache.org/r/73764/diff/1/
> 
> 
> Testing
> -------
> 
> Tested against XSS attack.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/#review223911
-----------------------------------------------------------




dashboardv2/public/js/utils/CommonViewFunction.js
Line 19 (original), 19 (patched)
<https://reviews.apache.org/r/73764/#comment312946>

    Remove DOMPurify dependency and use it in Utils.js as this will not required in this file.



dashboardv2/public/js/utils/CommonViewFunction.js
Lines 700 (patched)
<https://reviews.apache.org/r/73764/#comment312943>

    As this may be commonly used,make it as common function in Utils.js and use.



dashboardv2/public/js/utils/CommonViewFunction.js
Lines 758 (patched)
<https://reviews.apache.org/r/73764/#comment312944>

    As this may be commonly used,make it as common function in Utils.js and use.



dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/73764/#comment312947>

    Remove DOMPurify dependency and use it in Utils.js as this will not required in this file.



dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js
Lines 311 (patched)
<https://reviews.apache.org/r/73764/#comment312945>

    As this may be commonly used,make it as common function in Utils.js and use.



dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js
Line 303 (original), 317 (patched)
<https://reviews.apache.org/r/73764/#comment312953>

    make it in one variable and use it in html & text property.



dashboardv3/public/js/utils/CommonViewFunction.js
Line 19 (original), 19 (patched)
<https://reviews.apache.org/r/73764/#comment312948>

    Remove DOMPurify dependency and use it in Utils.js as this will not required in this file.



dashboardv3/public/js/utils/CommonViewFunction.js
Lines 720 (patched)
<https://reviews.apache.org/r/73764/#comment312950>

    As this may be commonly used,make it as common function in Utils.js and use.



dashboardv3/public/js/utils/CommonViewFunction.js
Lines 777 (patched)
<https://reviews.apache.org/r/73764/#comment312951>

    As this may be commonly used,make it as common function in Utils.js and use.



dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/73764/#comment312949>

    Remove DOMPurify dependency and use it in Utils.js as this will not required in this file.



dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js
Lines 325 (patched)
<https://reviews.apache.org/r/73764/#comment312952>

    As this may be commonly used,make it as common function in Utils.js and use.



dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js
Line 318 (original), 331 (patched)
<https://reviews.apache.org/r/73764/#comment312954>

    make it in one variable and use it in html & text property.


- Prasad Pawar


On Dec. 16, 2021, 12:58 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73764/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2021, 12:58 p.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4471
>     https://issues.apache.org/jira/browse/ATLAS-4471
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added text-editor for long-description field for Glossary/Term/Category to support formatting.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/common.scss 5bf8b6131 
>   dashboardv2/public/css/scss/override.scss 94548ffa4 
>   dashboardv2/public/css/scss/style.scss 9f4482c27 
>   dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
>   dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
>   dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
>   dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
>   dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
>   dashboardv2/public/js/main.js f2ea1d816 
>   dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
>   dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
>   dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
>   dashboardv3/public/css/scss/common.scss 9310e20cb 
>   dashboardv3/public/css/scss/override.scss fb3604d92 
>   dashboardv3/public/css/scss/style.scss 37d5458bc 
>   dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
>   dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
>   dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
>   dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
>   dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
>   dashboardv3/public/js/main.js 97e177c70 
>   dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
>   dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
>   dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 
> 
> 
> Diff: https://reviews.apache.org/r/73764/diff/1/
> 
> 
> Testing
> -------
> 
> Tested against XSS attack.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/
-----------------------------------------------------------

(Updated Jan. 7, 2022, 1:38 p.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4471
    https://issues.apache.org/jira/browse/ATLAS-4471


Repository: atlas


Description
-------

Added text-editor for long-description field for Glossary/Term/Category to support formatting.


Diffs (updated)
-----

  dashboardv2/public/css/scss/common.scss 5bf8b6131 
  dashboardv2/public/css/scss/override.scss 94548ffa4 
  dashboardv2/public/css/scss/style.scss 9f4482c27 
  dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv2/public/js/main.js f2ea1d816 
  dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
  dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
  dashboardv2/public/js/utils/Utils.js f2498d827 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
  dashboardv3/public/css/scss/common.scss 9310e20cb 
  dashboardv3/public/css/scss/override.scss fb3604d92 
  dashboardv3/public/css/scss/style.scss 37d5458bc 
  dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv3/public/js/main.js 97e177c70 
  dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
  dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
  dashboardv3/public/js/utils/Utils.js c3122fc20 
  dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 


Diff: https://reviews.apache.org/r/73764/diff/5/

Changes: https://reviews.apache.org/r/73764/diff/4-5/


Testing
-------

Tested against XSS attack.


Thanks,

Farhan Khan


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/
-----------------------------------------------------------

(Updated Jan. 7, 2022, 1:04 p.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4471
    https://issues.apache.org/jira/browse/ATLAS-4471


Repository: atlas


Description
-------

Added text-editor for long-description field for Glossary/Term/Category to support formatting.


Diffs (updated)
-----

  dashboardv2/public/css/scss/common.scss 5bf8b6131 
  dashboardv2/public/css/scss/override.scss 94548ffa4 
  dashboardv2/public/css/scss/style.scss 9f4482c27 
  dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv2/public/js/main.js f2ea1d816 
  dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
  dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
  dashboardv2/public/js/utils/Utils.js f2498d827 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
  dashboardv3/public/css/scss/common.scss 9310e20cb 
  dashboardv3/public/css/scss/override.scss fb3604d92 
  dashboardv3/public/css/scss/style.scss 37d5458bc 
  dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv3/public/js/main.js 97e177c70 
  dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
  dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
  dashboardv3/public/js/utils/Utils.js c3122fc20 
  dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 


Diff: https://reviews.apache.org/r/73764/diff/4/

Changes: https://reviews.apache.org/r/73764/diff/3-4/


Testing
-------

Tested against XSS attack.


Thanks,

Farhan Khan


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/#review223924
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On Jan. 4, 2022, 6:09 a.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73764/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2022, 6:09 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4471
>     https://issues.apache.org/jira/browse/ATLAS-4471
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added text-editor for long-description field for Glossary/Term/Category to support formatting.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/common.scss 5bf8b6131 
>   dashboardv2/public/css/scss/override.scss 94548ffa4 
>   dashboardv2/public/css/scss/style.scss 9f4482c27 
>   dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
>   dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
>   dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
>   dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
>   dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
>   dashboardv2/public/js/main.js f2ea1d816 
>   dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
>   dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
>   dashboardv2/public/js/utils/Utils.js f2498d827 
>   dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
>   dashboardv3/public/css/scss/common.scss 9310e20cb 
>   dashboardv3/public/css/scss/override.scss fb3604d92 
>   dashboardv3/public/css/scss/style.scss 37d5458bc 
>   dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
>   dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
>   dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
>   dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
>   dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
>   dashboardv3/public/js/main.js 97e177c70 
>   dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
>   dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
>   dashboardv3/public/js/utils/Utils.js c3122fc20 
>   dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 
> 
> 
> Diff: https://reviews.apache.org/r/73764/diff/3/
> 
> 
> Testing
> -------
> 
> Tested against XSS attack.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/
-----------------------------------------------------------

(Updated Jan. 4, 2022, 6:09 a.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4471
    https://issues.apache.org/jira/browse/ATLAS-4471


Repository: atlas


Description
-------

Added text-editor for long-description field for Glossary/Term/Category to support formatting.


Diffs (updated)
-----

  dashboardv2/public/css/scss/common.scss 5bf8b6131 
  dashboardv2/public/css/scss/override.scss 94548ffa4 
  dashboardv2/public/css/scss/style.scss 9f4482c27 
  dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv2/public/js/main.js f2ea1d816 
  dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
  dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
  dashboardv2/public/js/utils/Utils.js f2498d827 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
  dashboardv3/public/css/scss/common.scss 9310e20cb 
  dashboardv3/public/css/scss/override.scss fb3604d92 
  dashboardv3/public/css/scss/style.scss 37d5458bc 
  dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv3/public/js/main.js 97e177c70 
  dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
  dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
  dashboardv3/public/js/utils/Utils.js c3122fc20 
  dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 


Diff: https://reviews.apache.org/r/73764/diff/3/

Changes: https://reviews.apache.org/r/73764/diff/2-3/


Testing
-------

Tested against XSS attack.


Thanks,

Farhan Khan


Re: Review Request 73764: ATLAS-4471 :- UI: Add text editor for long description fields

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73764/
-----------------------------------------------------------

(Updated Jan. 3, 2022, 1:35 p.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4471
    https://issues.apache.org/jira/browse/ATLAS-4471


Repository: atlas


Description
-------

Added text-editor for long-description field for Glossary/Term/Category to support formatting.


Diffs (updated)
-----

  dashboardv2/public/css/scss/common.scss 5bf8b6131 
  dashboardv2/public/css/scss/override.scss 94548ffa4 
  dashboardv2/public/css/scss/style.scss 9f4482c27 
  dashboardv2/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv2/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv2/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv2/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv2/public/js/main.js f2ea1d816 
  dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b81f749ce 
  dashboardv2/public/js/utils/CommonViewFunction.js f7400c230 
  dashboardv2/public/js/utils/Utils.js f2498d827 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 0a1316267 
  dashboardv3/public/css/scss/common.scss 9310e20cb 
  dashboardv3/public/css/scss/override.scss fb3604d92 
  dashboardv3/public/css/scss/style.scss 37d5458bc 
  dashboardv3/public/css/scss/texteditor.scss PRE-CREATION 
  dashboardv3/public/css/scss/trumbowyg.scss PRE-CREATION 
  dashboardv3/public/js/external_lib/dompurify/purify.min.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js PRE-CREATION 
  dashboardv3/public/js/external_lib/trumbowyg/ui/icons.svg PRE-CREATION 
  dashboardv3/public/js/main.js 97e177c70 
  dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 23a5d84fe 
  dashboardv3/public/js/utils/CommonViewFunction.js 07954c0e4 
  dashboardv3/public/js/utils/Utils.js c3122fc20 
  dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 79622dcf8 


Diff: https://reviews.apache.org/r/73764/diff/2/

Changes: https://reviews.apache.org/r/73764/diff/1-2/


Testing
-------

Tested against XSS attack.


Thanks,

Farhan Khan