RE: Newlines in svn:author

[Sander Striker <st...@apache.org>]

> From: Sander Striker [mailto:striker@apache.org]
> Sent: Thursday, July 17, 2003 11:39 AM

> I may have missed the discussion around this.  I'm not so sure I
> like the idea of newlines in the svn:author tag (nor an option to
> allow it).  Can someone reiterate the issue?

Ok, I just saw the reference to #1401.  Stripping the newline(s) at the
end of the propval like pmarek suggests makes sense in a way.

AFAICT, this commit will error when svn:author contains a newline
(even at the end).  And --force will dismiss the check and commit
the propval as is.

Is this the desired behaviour?


Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Newlines in svn:author

[Branko Čibej <br...@xbc.nu>]

pmarek@users.sourceforge.net wrote:

>>Ok, I just saw the reference to #1401.  Stripping the newline(s) at the
>>end of the propval like pmarek suggests makes sense in a way.
>>
>>AFAICT, this commit will error when svn:author contains a newline
>>(even at the end).  And --force will dismiss the check and commit
>>the propval as is.
>>
>>Is this the desired behaviour?
>>    
>>
From my point of view - no.
>It still prohibits simple "svn pe svn:author" - I suggested *removing* a final 
>newline, at least for a defined set of properties; taking a newline away in 
>all properties will lead to messages like "missing newline at end of line", 
>"line not terminated", etc. in some programs.
>
>And if I remember to add the "--force" - "svn log" will be garbled.
>So there's no correct way to edit svn:author with a texteditor, which puts a 
>newline at the end of lines.
>
>I'd prefer to have the (last) newline stripped off per default, and by using 
>--force the message will be taken as-is.
>  
>
We have code to to force correct format (strip trailing and leading
spaces from svn:eol-style, for example) for nore props. We should just
reuse the same code for svn:author, svn:date, and other revision props.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Newlines in svn:author

[pm...@users.sourceforge.net]

> Ok, I just saw the reference to #1401.  Stripping the newline(s) at the
> end of the propval like pmarek suggests makes sense in a way.
>
> AFAICT, this commit will error when svn:author contains a newline
> (even at the end).  And --force will dismiss the check and commit
> the propval as is.
>
> Is this the desired behaviour?