[jira] Updated: (DBCP-255) Uninitialized read of parent field in AbandonedTrace

["Phil Steitz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated DBCP-255:
-----------------------------

    Attachment: AbandonedTracePatch.txt

Looks to me like this instance field is superfluous and can be removed.  Reads of this field in get/setLastUsed are null-guarded.  Unless I am missing something, the instance field will always be null.  The attached patch removes the field.  

> Uninitialized read of parent field in AbandonedTrace
> ----------------------------------------------------
>
>                 Key: DBCP-255
>                 URL: https://issues.apache.org/jira/browse/DBCP-255
>             Project: Commons Dbcp
>          Issue Type: Bug
>         Environment: Fortify
>            Reporter: Henri Yandell
>             Fix For: 1.3
>
>         Attachments: AbandonedTracePatch.txt
>
>
> Seems funky - we pass 'parent' up when constructing AbandonedTrace, but it's just null. Is that right, if it is, let's just put null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.