You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/12 01:51:19 UTC

[GitHub] [pulsar] horizonzy commented on pull request #15107: [fix] [client-consumer] Fix message discard problem when pending receives all done.

horizonzy commented on PR #15107:
URL: https://github.com/apache/pulsar/pull/15107#issuecomment-1095806601

   > @horizonzy - thanks for your contribution. Is this for a bug that you observed? If so, which version of the Pulsar client were you using? Based on my understanding of the client, the race that you are seeking to fix isn't possible because the `pendingReceives` queue is only supposed to be updated from the `internalPinnedExecutor`, which prevents data races.
   
   No, I did't found a clear bug here. I just see the code potential risks. So enhance it, sry, maybe my title is misleading. I change the title.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org