You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/08/13 04:11:59 UTC

Review Request 37430: Hosts Page Performance: Hosts page takes 2-3 seconds to render an 100 items page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37430/
-----------------------------------------------------------

Review request for Ambari and Jaimin Jetly.


Bugs: AMBARI-12757
    https://issues.apache.org/jira/browse/AMBARI-12757


Repository: ambari


Description
-------

Clean up loading condition. Remove redundant masking.


Diffs
-----

  ambari-web/app/controllers/main/host.js aa82645 
  ambari-web/app/routes/main.js de2f0a9 
  ambari-web/app/views/main/host.js e0f1cbf 
  ambari-web/app/views/main/menu.js d4d7ef3 
  ambari-web/test/views/main/host_test.js a63caca 

Diff: https://reviews.apache.org/r/37430/diff/


Testing
-------

Manually tested on live cluster. Unit test updated. All unit test passed.
  6485 tests complete (8 seconds)
  94 tests pending


Thanks,

Richard Zang


Re: Review Request 37430: Hosts Page Performance: Hosts page takes 2-3 seconds to render an 100 items page

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37430/#review95224
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On Aug. 13, 2015, 2:11 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37430/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 2:11 a.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-12757
>     https://issues.apache.org/jira/browse/AMBARI-12757
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clean up loading condition. Remove redundant masking.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host.js aa82645 
>   ambari-web/app/routes/main.js de2f0a9 
>   ambari-web/app/views/main/host.js e0f1cbf 
>   ambari-web/app/views/main/menu.js d4d7ef3 
>   ambari-web/test/views/main/host_test.js a63caca 
> 
> Diff: https://reviews.apache.org/r/37430/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster. Unit test updated. All unit test passed.
>   6485 tests complete (8 seconds)
>   94 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>