You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Max Bowsher (JIRA)" <ji...@codehaus.org> on 2008/02/10 01:27:28 UTC

[jira] Created: (MASSEMBLY-280) Regression: Dependency resolution for dependencySets does broken things

Regression: Dependency resolution for dependencySets does broken things
-----------------------------------------------------------------------

                 Key: MASSEMBLY-280
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-280
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
    Affects Versions: 2.2-beta-1
         Environment: Maven 2.0.8
            Reporter: Max Bowsher
            Priority: Blocker


With this POM:
{code:xml}
<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>test</groupId>
  <artifactId>test</artifactId>
  <version>0-SNAPSHOT</version>

  <dependencies>
    <dependency>
      <groupId>commons-jxpath</groupId>
      <artifactId>commons-jxpath</artifactId>
      <version>1.1</version>
    </dependency>
    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>3.8.1</version>
      <scope>test</scope>
    </dependency>
  </dependencies>
</project>
{code}

run:
{noformat}
mvn org.apache.maven.plugins:maven-assembly-plugin:VERSION:assembly -DdescriptorId=jar-with-dependencies
{noformat}

VERSION = 2.1 -> as expected, junit is not included because it is scope test
VERSION = 2.2-beta-1 or 2.2-beta-2-SNAPSHOT -> junit is erroneously included in jar-with-dependencies.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-280) Regression: Dependency resolution for dependencySets does broken things

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=128491#action_128491 ] 

John Casey commented on MASSEMBLY-280:
--------------------------------------

We have an integration test that covers this case (specifically, that junit in test scope should be left out of a jar-with-dependencies assembly). If you checkout:

http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-assembly-plugin

and run:

mvn -Dit.pomIncludes=descriptor-refs/jar-with-dependencies/deps-unpacked-to-root-dir -Pintegration-tests clean integration-test

You should see it run. You can examine the results in:

target/test-classes/projects/descriptor-refs/jar-with-dependencies/deps-unpacked-to-root-dir/build.log

and check the logic that we use to verify that junit is left out of the resulting assembly jar by having a look at:

target/test-classes/projects/descriptor-refs/jar-with-dependencies/deps-unpacked-to-root-dir/verify.bsh

After taking a look at this, can you tell me whether we've missed something in this test that is expressed in your own use case? Alternatively, can you attach a failing test case that I can use to replicate the problem, so I can investigate a solution?

> Regression: Dependency resolution for dependencySets does broken things
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-280
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-280
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-1
>         Environment: Maven 2.0.8
>            Reporter: Max Bowsher
>            Priority: Blocker
>             Fix For: 2.2-beta-3
>
>
> With this POM:
> {code:xml}
> <project>
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>test</groupId>
>   <artifactId>test</artifactId>
>   <version>0-SNAPSHOT</version>
>   <dependencies>
>     <dependency>
>       <groupId>commons-jxpath</groupId>
>       <artifactId>commons-jxpath</artifactId>
>       <version>1.1</version>
>     </dependency>
>     <dependency>
>       <groupId>junit</groupId>
>       <artifactId>junit</artifactId>
>       <version>3.8.1</version>
>       <scope>test</scope>
>     </dependency>
>   </dependencies>
> </project>
> {code}
> run:
> {noformat}
> mvn org.apache.maven.plugins:maven-assembly-plugin:VERSION:assembly -DdescriptorId=jar-with-dependencies
> {noformat}
> VERSION = 2.1 -> as expected, junit is not included because it is scope test
> VERSION = 2.2-beta-1 or 2.2-beta-2-SNAPSHOT -> junit is erroneously included in jar-with-dependencies.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-280) Regression: Dependency resolution for dependencySets does broken things

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MASSEMBLY-280:
---------------------------------

    Fix Version/s: 2.2-beta-3

> Regression: Dependency resolution for dependencySets does broken things
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-280
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-280
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-1
>         Environment: Maven 2.0.8
>            Reporter: Max Bowsher
>            Priority: Blocker
>             Fix For: 2.2-beta-3
>
>
> With this POM:
> {code:xml}
> <project>
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>test</groupId>
>   <artifactId>test</artifactId>
>   <version>0-SNAPSHOT</version>
>   <dependencies>
>     <dependency>
>       <groupId>commons-jxpath</groupId>
>       <artifactId>commons-jxpath</artifactId>
>       <version>1.1</version>
>     </dependency>
>     <dependency>
>       <groupId>junit</groupId>
>       <artifactId>junit</artifactId>
>       <version>3.8.1</version>
>       <scope>test</scope>
>     </dependency>
>   </dependencies>
> </project>
> {code}
> run:
> {noformat}
> mvn org.apache.maven.plugins:maven-assembly-plugin:VERSION:assembly -DdescriptorId=jar-with-dependencies
> {noformat}
> VERSION = 2.1 -> as expected, junit is not included because it is scope test
> VERSION = 2.2-beta-1 or 2.2-beta-2-SNAPSHOT -> junit is erroneously included in jar-with-dependencies.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MASSEMBLY-280) Regression: Dependency resolution for dependencySets does broken things

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MASSEMBLY-280.
--------------------------------

      Assignee: John Casey
    Resolution: Cannot Reproduce

> Regression: Dependency resolution for dependencySets does broken things
> -----------------------------------------------------------------------
>
>                 Key: MASSEMBLY-280
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-280
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-1
>         Environment: Maven 2.0.8
>            Reporter: Max Bowsher
>            Assignee: John Casey
>            Priority: Blocker
>             Fix For: 2.2-beta-3
>
>
> With this POM:
> {code:xml}
> <project>
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>test</groupId>
>   <artifactId>test</artifactId>
>   <version>0-SNAPSHOT</version>
>   <dependencies>
>     <dependency>
>       <groupId>commons-jxpath</groupId>
>       <artifactId>commons-jxpath</artifactId>
>       <version>1.1</version>
>     </dependency>
>     <dependency>
>       <groupId>junit</groupId>
>       <artifactId>junit</artifactId>
>       <version>3.8.1</version>
>       <scope>test</scope>
>     </dependency>
>   </dependencies>
> </project>
> {code}
> run:
> {noformat}
> mvn org.apache.maven.plugins:maven-assembly-plugin:VERSION:assembly -DdescriptorId=jar-with-dependencies
> {noformat}
> VERSION = 2.1 -> as expected, junit is not included because it is scope test
> VERSION = 2.2-beta-1 or 2.2-beta-2-SNAPSHOT -> junit is erroneously included in jar-with-dependencies.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira