You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "xumingming (via GitHub)" <gi...@apache.org> on 2024/03/19 23:16:53 UTC
[PR] [GLUTEN-5027][VL] Fail fast for unsupported compilers [incubator-gluten]
xumingming opened a new pull request, #5030:
URL: https://github.com/apache/incubator-gluten/pull/5030
## What changes were proposed in this pull request?
Currently when unsupported compiler is detected, the build is not failed, just a message is logged, causing strange errors thrown later. By fail fast, it gives user a clear message what is going on.
Fixes: #5027
## How was this patch tested?
Manual tested on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5027][VL] Fail fast for unsupported compilers [incubator-gluten]
Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming commented on PR #5030:
URL: https://github.com/apache/incubator-gluten/pull/5030#issuecomment-2010853337
@FelixYBW Would you take a look at this one? Very simple but useful one I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5027][VL] Fail fast for unsupported compilers [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW merged PR #5030:
URL: https://github.com/apache/incubator-gluten/pull/5030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5027][VL] Fail fast for unsupported compilers [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5030:
URL: https://github.com/apache/incubator-gluten/pull/5030#issuecomment-2008328250
https://github.com/apache/incubator-gluten/issues/5027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org