You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/14 14:59:55 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8112: libc: Let _SC_PAGESIZE return 4096 when CONFIG_MM_PGSIZE isn't defined
xiaoxiang781216 opened a new pull request, #8112:
URL: https://github.com/apache/nuttx/pull/8112
## Summary
since most application doesn't expect the page size equals one
## Impact
_SC_PAGESIZE
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8112: libc: Let _SC_PAGESIZE return 4096 when CONFIG_MM_PGSIZE isn't defined
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #8112:
URL: https://github.com/apache/nuttx/pull/8112#discussion_r1070301855
##########
libs/libc/unistd/lib_sysconf.c:
##########
@@ -229,7 +229,7 @@ long sysconf(int name)
#ifdef CONFIG_MM_PGSIZE
return CONFIG_MM_PGSIZE;
#else
- return 1;
+ return 4096;
Review Comment:
Please define something like DEFAULT_MM_PGSIZE and return it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8112: libc: Let _SC_PAGESIZE return 4096 when CONFIG_MM_PGSIZE isn't defined
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #8112:
URL: https://github.com/apache/nuttx/pull/8112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8112: libc: Let _SC_PAGESIZE return 4096 when CONFIG_MM_PGSIZE isn't defined
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8112:
URL: https://github.com/apache/nuttx/pull/8112#discussion_r1070317444
##########
libs/libc/unistd/lib_sysconf.c:
##########
@@ -229,7 +229,7 @@ long sysconf(int name)
#ifdef CONFIG_MM_PGSIZE
return CONFIG_MM_PGSIZE;
#else
- return 1;
+ return 4096;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org