You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/06 22:13:26 UTC
[GitHub] [incubator-gobblin] zxcware opened a new pull request #3118: [GOBBLIN-1278] Close HiveRegister in completion action usage
zxcware opened a new pull request #3118:
URL: https://github.com/apache/incubator-gobblin/pull/3118
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-1278
### Description
- [x] Here are some details about my PR:
- In a compaction with watermark flow, `CompactionHiveRegistrationAction` and `CompactionWatermarkAction` can concurrently alter a table, which may end up old table parameters replace new ones. To serialize, the idea is to `close` the `HiveRegister` instance, waiting for all hive updates complete, before returning.
### Tests
- [] My PR adds the following tests:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3118: [GOBBLIN-1278] Close HiveRegister in completion action usage
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3118:
URL: https://github.com/apache/incubator-gobblin/pull/3118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3118: [GOBBLIN-1278] Close HiveRegister in completion action usage
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3118:
URL: https://github.com/apache/incubator-gobblin/pull/3118#issuecomment-704601243
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1cf79ef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3118 +/- ##
=========================================
Coverage ? 41.74%
Complexity ? 8736
=========================================
Files ? 1986
Lines ? 75793
Branches ? 8445
=========================================
Hits ? 31642
Misses ? 41132
Partials ? 3019
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ction/action/CompactionHiveRegistrationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3118/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25IaXZlUmVnaXN0cmF0aW9uQWN0aW9uLmphdmE=) | `37.50% <33.33%> (ø)` | `4.00 <0.00> (?)` | |
| [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3118/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | `76.66% <76.92%> (ø)` | `11.00 <0.00> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=footer). Last update [1cf79ef...6dc0076](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org