You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/07 04:25:17 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4195: Remove SQLVisitor
terrymanu opened a new pull request #4195: Remove SQLVisitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4195
Fixes #3914.
Use ParseTreeVisitor instead of SQLVisitor. Avoid create a new interface to increase complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4195:
Remove SQLVisitor
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4195: Remove SQLVisitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4195:
Remove SQLVisitor
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4195: Remove SQLVisitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4195#issuecomment-583236419
## Pull Request Test Coverage Report for [Build 9355](https://coveralls.io/builds/28582499)
* **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **64.749%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28582499/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L107) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **1** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/28582499) |
| :-- | --: |
| Change from base [Build 9354](https://coveralls.io/builds/28581890): | 0.0% |
| Covered Lines: | 10960 |
| Relevant Lines: | 16927 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services