You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/13 07:58:06 UTC
[GitHub] [apisix] membphis commented on a change in pull request #3253: chore: fix spelling
membphis commented on a change in pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#discussion_r556324270
##########
File path: t/plugin/batch-requests.t
##########
@@ -988,7 +988,7 @@ passed
GET /t
--- error_code: 400
--- response_body eval
-qr/\{"error_msg":"invalid configuration: property \\"max_body_size\\" validation failed: expected 0 to be sctrictly greater than 0"\}/
+qr/\{"error_msg":"invalid configuration: property \\"max_body_size\\" validation failed: expected 0 to be strictly greater than 0"\}/
Review comment:
I think we need to update the source code and release a new version:
https://github.com/api7/jsonschema/search?q=sctrictly
##########
File path: t/plugin/batch-requests.t
##########
@@ -988,7 +988,7 @@ passed
GET /t
--- error_code: 400
--- response_body eval
-qr/\{"error_msg":"invalid configuration: property \\"max_body_size\\" validation failed: expected 0 to be sctrictly greater than 0"\}/
+qr/\{"error_msg":"invalid configuration: property \\"max_body_size\\" validation failed: expected 0 to be strictly greater than 0"\}/
Review comment:
I created a new issue: https://github.com/api7/jsonschema/issues/51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org