You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/06 17:19:12 UTC
[GitHub] [cassandra] dcapwell opened a new pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs
dcapwell opened a new pull request #953:
URL: https://github.com/apache/cassandra/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #953:
URL: https://github.com/apache/cassandra/pull/953#discussion_r608422692
##########
File path: .build/build-resolver.xml
##########
@@ -67,44 +73,69 @@
<remoterepo id="resolver-apache" url="${artifact.remoteRepository.apache}"/>
</resolver:remoterepos>
- <resolver:resolve>
- <remoterepos refid="all"/>
+ <!-- resolve doesn't really retry, so need to explicitly add extra retries to get stable -->
+ <macrodef name="resolve">
+ <!--
+ Address retries and defaults repos while setting up a resolver:resolve block
+ -->
+ <attribute name="failonmissingattachments" default="true"/>
+ <element name="elements" implicit="yes"/>
+ <sequential>
+ <retry retrycount="3">
Review comment:
i like it! This is going to strengthen CI too where I've seen downloads often fail…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #953:
URL: https://github.com/apache/cassandra/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #953:
URL: https://github.com/apache/cassandra/pull/953#discussion_r608422692
##########
File path: .build/build-resolver.xml
##########
@@ -67,44 +73,69 @@
<remoterepo id="resolver-apache" url="${artifact.remoteRepository.apache}"/>
</resolver:remoterepos>
- <resolver:resolve>
- <remoterepos refid="all"/>
+ <!-- resolve doesn't really retry, so need to explicitly add extra retries to get stable -->
+ <macrodef name="resolve">
+ <!--
+ Address retries and defaults repos while setting up a resolver:resolve block
+ -->
+ <attribute name="failonmissingattachments" default="true"/>
+ <element name="elements" implicit="yes"/>
+ <sequential>
+ <retry retrycount="3">
Review comment:
i like it! This is going to strength CI too where I've seen a download fail…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #953:
URL: https://github.com/apache/cassandra/pull/953#discussion_r608866013
##########
File path: .build/build-resolver.xml
##########
@@ -30,8 +30,14 @@
<available file="${resolver-ant-tasks.local}" />
</condition>
- <!-- version of lib/ downloads -->
+ <property name="artifact.python.pypi" value="https://files.pythonhosted.org/packages" />
+ <property name="artifact.github.release" value="https://github.com" />
+
+ <!-- some artifacts are fetched from github as blobs; these are all in the cassandra project, but in an older commit -->
<property name="lib.download.sha" value="1371883db3d8bf7d7c54e0baaca89c6c2d2a5abe"/>
+ <property name="lib.download.address" value="raw.githubusercontent.com" />
Review comment:
I forgot to remove this, will drop before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #953: CASSANDRA-16563 - When behind a firewall trunk is not buildable, need to allow overriding URLs
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #953:
URL: https://github.com/apache/cassandra/pull/953#discussion_r608422692
##########
File path: .build/build-resolver.xml
##########
@@ -67,44 +73,69 @@
<remoterepo id="resolver-apache" url="${artifact.remoteRepository.apache}"/>
</resolver:remoterepos>
- <resolver:resolve>
- <remoterepos refid="all"/>
+ <!-- resolve doesn't really retry, so need to explicitly add extra retries to get stable -->
+ <macrodef name="resolve">
+ <!--
+ Address retries and defaults repos while setting up a resolver:resolve block
+ -->
+ <attribute name="failonmissingattachments" default="true"/>
+ <element name="elements" implicit="yes"/>
+ <sequential>
+ <retry retrycount="3">
Review comment:
i like it! This is going to strength CI too where I've seen downloads often fail…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org