[GitHub] [cassandra] maedhroz commented on a diff in pull request #2120: CASSANDRA-18195 Feature Flag for Accord Transactions

["maedhroz (via GitHub)" <gi...@apache.org>]

maedhroz commented on code in PR #2120:
URL: https://github.com/apache/cassandra/pull/2120#discussion_r1091365847


##########
test/conf/cassandra.yaml:
##########
@@ -53,6 +53,7 @@ materialized_views_enabled: true
 drop_compact_storage_enabled: true
 file_cache_enabled: true
 auto_hints_cleanup_enabled: true
+accord_transactions_enabled: true

Review Comment:
   I changed it in `AccordTestBase`, of course, but outside that, my goal was to keep the rest of the in-JVM test landscape running w/ the default, which right now means `accord_transactions_enabled: false`. Right trade-off, or am I thinking about it wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org