[jira] [Commented] (FINERACT-574) Issues related to share Account Creation

["Vishwas Babu A J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782499#comment-16782499 ] 

Vishwas Babu A J commented on FINERACT-574:
-------------------------------------------

[~Shruthi M R] and [~santoshmath] : Reconfirming that this issue is working as expected?

1) On [https://github.com/apache/fineract/commit/3bdfa5abe10f1299104247ae92ec3a6b51fccbe8] , the credit and debit are for different amounts

2) The integration test "rejectShareAccount" fails. The cause of the failure is as follows, one of the JSON elements "purchasedShares" retrieved while fetching a share account is as follows
{code:java}
purchasedShares=[{accountId=15, amount=52.0, amountPaid=50.0, numberOfShares=25, purchasedDate=[2016, 1, 1], chargeAmount=2.0, id=30, type={code=purchasedSharesType.purchased, id=500, value=Purchase}, purchasedPrice=2.0, status={code=purchasedSharesStatusType.applied, id=100, value=Pending Approval}}, {accountId=15, amount=2.0, amountPaid=0, purchasedDate=[2019, 3, 1], chargeAmount=0, id=31, type={code=charge.payment, id=700, value=Charge Payment}, status={code=purchasedSharesStatusType.approved, id=300, value=Approved}}]
{code}
Note that here, for the share purchase the amount is 52 (sum of share amount + charge) while the amount paid is 50 when the share is in approved state.

When the share moves to rejected state. the JSON element "purchasedShares" now changes to 
{code:java}
[{accountId=15, amount=50.0, amountPaid=50.0, numberOfShares=25, purchasedDate=[2016, 1, 1], chargeAmount=2.0, id=30, type={code=purchasedSharesType.purchased, id=500, value=Purchase}, purchasedPrice=2.0, status={code=purchasedSharesStatusType.rejected, id=400, value=Rejected}}, {accountId=15, amount=2.0, amountPaid=0, purchasedDate=[2019, 3, 1], chargeAmount=0, id=31, type={code=charge.payment, id=700, value=Charge Payment}, status={code=purchasedSharesStatusType.approved, id=300, value=Approved}}]
{code}
 i.e the amount changes from 50 from 52.

Ideally, the API response should be consistent. If there is a rationale for the change, please update the Integration test accordingly. For now, this integration test has been Ignored to ensure that the build does not break

 

> Issues related to share Account Creation
> ----------------------------------------
>
>                 Key: FINERACT-574
>                 URL: https://issues.apache.org/jira/browse/FINERACT-574
>             Project: Apache Fineract
>          Issue Type: Bug
>          Components: Shares
>            Reporter: Santosh Math
>            Assignee: Santosh Math
>            Priority: Critical
>              Labels: gci, gsoc, p1
>             Fix For: 1.3.0
>
>         Attachments: Screenshot from 2017-12-12 21-05-47.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> 1. Create Share  Product with Accounting Enabled 
> 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2.
> 3. Create and activate savings account for client which is needed to link with share account
> 4.  Create a share Account application for current date using above product and charge and number of shares issued as 10 , each share price as $0.5.
> > Once you 'Submit' the share application journal entries are created (including charge) even though share account is not yet approved/activated.
> >Approve the share account and again duplicate jounal entries are created. 
> >If share account application is attached with 'Share Activation Fee' , upon submission of share account application, if we check 'Transaction Overview' tab, it shows 'Activation Fee' is received even though share account is not activated. Same is updated in the database table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it shows Outstanding(which is correct).
> The all scenarios can be tested here by modifying application and using the charges 
> 'Share Purchase Fee'  or  'Share Activation Fee'
> https://staging.openmf.org/#/viewshareaccount/5



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)