[jira] [Commented] (CALCITE-5678) Validate incorrect datetime string representation.

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717241#comment-17717241 ] 

Julian Hyde commented on CALCITE-5678:
--------------------------------------

Your summary describes what you think is the fix, not the actual problem. The actual problem is that users can type SQL with invalid date literals. You should write a test case with the desired error message and work back from that.

> Validate incorrect datetime string representation.
> --------------------------------------------------
>
>                 Key: CALCITE-5678
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5678
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>    Affects Versions: 1.34.0
>            Reporter: Evgeny Stanilovsky
>            Assignee: Evgeny Stanilovsky
>            Priority: Major
>              Labels: patch-available
>
> RexToLixTranslator now process datetime input string representation through org.apache.calcite.avatica.util.DateTimeUtils#timestampStringToUnixDate , thus no exception is raised if incorrect string is passed.
> {noformat}
> create table t (i int not null, j timestamp);
> insert into t values (1, '2013-20-14 00:00:00');
> select * from t;
> > +---+---------------------+
> > | I | J                   |
> > +---+---------------------+
> > | 1 | 2014-08-16 00:00:00 |
> > +---+---------------------+{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)