You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/05/17 09:02:53 UTC
[PR] GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ [arrow]
jorisvandenbossche opened a new pull request, #41705:
URL: https://github.com/apache/arrow/pull/41705
### Rationale for this change
Follow-up on https://github.com/apache/arrow/pull/41494 to update the Python development guide to reflect the change in how PyArrow is build (defaults for the various `PYARROW_BUILD_<component>` are now set based on the `ARROW_<component>` setting. The current `PYARROW_WITH_<component>` environment variables are kept working to allow to override this default)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #41705:
URL: https://github.com/apache/arrow/pull/41705#discussion_r1604902935
##########
docs/source/developers/python.rst:
##########
@@ -678,6 +642,45 @@ PyArrow are:
- Number of processes used to compile PyArrow’s C++/Cython components
- ``''``
+The components being disabled or enabled when building PyArrrow is by default
+based on how Arrow C++ is build (i.e. it follows the ``ARROW_$COMPONENT`` flags).
+However, the ``PYARROW_WITH_$COMPONENT`` environment variables can still be used
+to override this when building PyArrow (e.g. to disable components, or to enforce
+certain components to be built):
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
Review Comment:
This list is bound to become outdated. Could we link to (or auto generate from) the relevant CMake file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #41705:
URL: https://github.com/apache/arrow/pull/41705#issuecomment-2117473369
Thanks for documenting Joris! Super happy this won't cause friction anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41705:
URL: https://github.com/apache/arrow/pull/41705#issuecomment-2167263236
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit aea10c2b59043397639a80c7582a1d3e5c588125.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/26217335726) has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #41705:
URL: https://github.com/apache/arrow/pull/41705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #41705:
URL: https://github.com/apache/arrow/pull/41705#discussion_r1604917926
##########
docs/source/developers/python.rst:
##########
@@ -678,6 +642,45 @@ PyArrow are:
- Number of processes used to compile PyArrow’s C++/Cython components
- ``''``
+The components being disabled or enabled when building PyArrrow is by default
+based on how Arrow C++ is build (i.e. it follows the ``ARROW_$COMPONENT`` flags).
+However, the ``PYARROW_WITH_$COMPONENT`` environment variables can still be used
+to override this when building PyArrow (e.g. to disable components, or to enforce
+certain components to be built):
+
+.. list-table::
+ :widths: 30 30
+ :header-rows: 1
+
+ * - Arrow flags/options
+ - Corresponding environment variables for PyArrow
Review Comment:
We don't really have a good place we could link to, because in the CMakeLists file, the env variables are not directly visible (they are constructed and checked in a macro)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org