You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "hughhhh (GitHub)" <gi...@apache.org> on 2018/08/22 01:06:51 UTC

[GitHub] [incubator-superset] hughhhh opened pull request #5694: [WIP] Allow users to select color for big number

Added color picker control to BigNumber Viz

- [ ] Make color change instantly
- [ ] Create rgbToHex module

![big_number_colors](https://user-images.githubusercontent.com/27827808/44436983-d4338f80-a56c-11e8-89ca-20d35b9d7543.gif)


[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
I was surprised to see that color isn't `renderTrigger: true`, looks like `color` isn't used anywhere, but `color_picker` is and behaves as expected.

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] kristw commented on issue #5694: Allow users to select color for big number

Posted by "kristw (GitHub)" <gi...@apache.org>.
@hughhhh Code looks good. One question is what is the default color then? If user did not set `userColor`, can it default to `brandColor`?

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
Use the function in `colors.js`

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
oops

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5694: Allow users to select color for big number

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=h1) Report
> Merging [#5694](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80e777823bc4b2f71acec0fd2f0507e82f64dd22?src=pr&el=desc) will **decrease** coverage by `0.85%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5694/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5694      +/-   ##
==========================================
- Coverage   63.49%   62.64%   -0.86%     
==========================================
  Files         360      361       +1     
  Lines       22934    23440     +506     
  Branches     2555     2697     +142     
==========================================
+ Hits        14562    14684     +122     
- Misses       8357     8741     +384     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/visTypes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpzeA==) | `55.81% <ø> (-1.33%)` | :arrow_down: |
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `44.63% <0%> (-1.3%)` | :arrow_down: |
| [superset/assets/src/visualizations/nvd3\_vis.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9udmQzX3Zpcy5qcw==) | `7.66% <0%> (-1.28%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.29% <0%> (-0.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.9% <0%> (-0.77%)` | :arrow_down: |
| [superset/assets/src/visualizations/word\_cloud.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy93b3JkX2Nsb3VkLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [...perset/assets/src/visualizations/directed\_force.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kaXJlY3RlZF9mb3JjZS5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [...isualizations/deckgl/AnimatableDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQW5pbWF0YWJsZURlY2tHTENvbnRhaW5lci5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=footer). Last update [80e7778...f7d5fdb](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5694: Allow users to select color for big number

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=h1) Report
> Merging [#5694](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80e777823bc4b2f71acec0fd2f0507e82f64dd22?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `14.28%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5694      +/-   ##
==========================================
- Coverage   63.49%   63.48%   -0.02%     
==========================================
  Files         360      360              
  Lines       22934    22941       +7     
  Branches     2555     2558       +3     
==========================================
+ Hits        14562    14563       +1     
- Misses       8357     8363       +6     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/visTypes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpzeA==) | `57.14% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL2NvbG9ycy5qcw==) | `72.22% <20%> (-5.33%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=footer). Last update [80e7778...23a07ab](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
I think you meant to use `rgbToHex` in `BigNumber.jsx`

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
@kristw it comes from `color_picker`, which has its default set to brand color, so we're good. https://github.com/apache/incubator-superset/blob/master/superset/assets/src/explore/controls.jsx#L241

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5694: Allow users to select color for big number

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=h1) Report
> Merging [#5694](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80e777823bc4b2f71acec0fd2f0507e82f64dd22?src=pr&el=desc) will **decrease** coverage by `0.8%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5694/graphs/tree.svg?width=650&src=pr&token=KsB0fHcx6l&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5694      +/-   ##
==========================================
- Coverage   63.49%   62.68%   -0.81%     
==========================================
  Files         360      361       +1     
  Lines       22934    23440     +506     
  Branches     2555     2697     +142     
==========================================
+ Hits        14562    14694     +132     
- Misses       8357     8731     +374     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/visTypes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpzeA==) | `55.81% <ø> (-1.33%)` | :arrow_down: |
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `44.63% <0%> (-1.3%)` | :arrow_down: |
| [superset/assets/src/visualizations/nvd3\_vis.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9udmQzX3Zpcy5qcw==) | `7.66% <0%> (-1.28%)` | :arrow_down: |
| [...et/assets/src/visualizations/deckgl/layers/arc.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL2FyYy5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/Legend.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9MZWdlbmQuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [...isualizations/deckgl/AnimatableDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQW5pbWF0YWJsZURlY2tHTENvbnRhaW5lci5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [...ts/src/visualizations/deckgl/layers/screengrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjcmVlbmdyaWQuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/word\_cloud.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy93b3JkX2Nsb3VkLmpz) | `0% <0%> (ø)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=footer). Last update [80e7778...f7d5fdb](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5694: Allow users to select color for big number

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=h1) Report
> Merging [#5694](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80e777823bc4b2f71acec0fd2f0507e82f64dd22?src=pr&el=desc) will **decrease** coverage by `0.69%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5694/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##           master    #5694     +/-   ##
=========================================
- Coverage   63.49%   62.79%   -0.7%     
=========================================
  Files         360      361      +1     
  Lines       22934    23535    +601     
  Branches     2555     2700    +145     
=========================================
+ Hits        14562    14779    +217     
- Misses       8357     8741    +384     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/visTypes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpzeA==) | `55.81% <ø> (-1.33%)` | :arrow_down: |
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `44.63% <0%> (-1.3%)` | :arrow_down: |
| [superset/assets/src/visualizations/nvd3\_vis.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9udmQzX3Zpcy5qcw==) | `7.66% <0%> (-1.28%)` | :arrow_down: |
| [...perset/assets/src/visualizations/directed\_force.js](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kaXJlY3RlZF9mb3JjZS5qcw==) | `0% <0%> (ø)` | :arrow_up: |
| [...et/assets/src/visualizations/deckgl/layers/arc.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL2FyYy5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/Legend.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9MZWdlbmQuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [...ts/src/visualizations/deckgl/layers/screengrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjcmVlbmdyaWQuanN4) | `0% <0%> (ø)` | :arrow_up: |
| [...isualizations/deckgl/AnimatableDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQW5pbWF0YWJsZURlY2tHTENvbnRhaW5lci5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/5694/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=footer). Last update [80e7778...4eb7eb5](https://codecov.io/gh/apache/incubator-superset/pull/5694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] kristw commented on pull request #5694: Allow users to select color for big number

Posted by "kristw (GitHub)" <gi...@apache.org>.
Can use `d3-color` instead of writing a new module

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] kristw commented on issue #5694: Allow users to select color for big number

Posted by "kristw (GitHub)" <gi...@apache.org>.
@hughhhh Code looks good. One question is what is the default color then?

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
Looks like it has the right default of brandPrimary too.

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch closed pull request #5694: Allow users to select color for big number

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
[ pull request closed by mistercrunch ]

[ Full content available at: https://github.com/apache/incubator-superset/pull/5694 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org