Re: [I] Refactor HoodieSourceOffset using Checkpoint interface [hudi]

["rangareddy (via GitHub)" <gi...@apache.org>]

rangareddy commented on issue #17317:
URL: https://github.com/apache/hudi/issues/17317#issuecomment-5365822193

   This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8625).
   
   **Findings: not done on `master`.**
   
   `hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala` exists and contains **no reference to `Checkpoint`** at all. The streaming source offset still carries its own representation rather than using the shared `org.apache.hudi.common.table.checkpoint.Checkpoint` abstraction.
   
   One sequencing note: the sibling #17318 (HUDI-8627) is a refactor of the checkpoint APIs themselves, and its complaint is that there are too many version-specific checkpoint classes - `StreamerCheckpointV1` and `StreamerCheckpointV2` are referenced across roughly 37 and 29 files respectively. Adopting that hierarchy here before #17318 settles its shape would mean reworking this twice. Worth linking the two and doing #17318 first.
   
   Keeping this open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org