[GitHub] [lucene-solr] sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup

[GitBox <gi...@apache.org>]

sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup
URL: https://github.com/apache/lucene-solr/pull/959#discussion_r335862773
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
 ##########
 @@ -431,12 +432,13 @@ public void register() {
       cache.setState(SolrCache.State.LIVE);
       infoRegistry.put(cache.name(), cache);
     }
-    metricManager = core.getCoreContainer().getMetricManager();
-    registryName = core.getCoreMetricManager().getRegistryName();
+    this.solrMetricsContext = core.getSolrMetricsContext().getChildContext(this);
 
 Review comment:
   `SolrIndexSearcher` is not a `SolrMetricProducer` but it registers some gauges so I think it needs a child context - especially since its life-cycle is different from that of SolrCore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org