You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/11/07 01:29:10 UTC
[GitHub] [phoenix] yanxinyi commented on a change in pull request #616:
PHOENIX-5432: Refactor LiteralExpression to use the builder pattern
yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern
URL: https://github.com/apache/phoenix/pull/616#discussion_r343411884
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
##########
@@ -380,7 +381,7 @@ public PDataType getViewIndexIdType() {
return viewIndexIdType;
}
- public static MetaDataMutationResult constructFromProto(MetaDataResponse proto) {
+ public static MetaDataMutationResult constructFromProto(MetaDataResponse proto) throws SQLException {
Review comment:
why we are adding extra `throws SQLException` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services