Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Eric Gillespie <ep...@pretzelnet.org>]

> + ------- Additional Comments From kfogel@tigris.org  2002-07-20 20:23 PDT --

> + This is because Subversion log entries are attached to revisions, not
> + files.

Er, huh?  Log entries are attached to revisions in CVS too.

> + When you run "svn log FILE_A FILE_B", you're really saying "show me
> + logs for all the revisions in which either FILE_A or FILE_B, or both,
> + changed".  Note that any given revision log should only be printed out

No, that's what you thought users would say.  That's not what i
said when i ran 'svn log foo bar'.  If you have a good reason to
believe that most users will be looking for that information, then
i guess i'll just have to make a zsh function svnlog that does what
i want.

But i don't think that's what people want; it doesn't sound
particularly useful.  I think when people give multiple files to
svn log, they want to see the history of each of those files.

> + once -- that is, if both FILE_A and FILE_B changed in that revision,
> + it won't be printed twice, only once.

I think it should be, but in separate sections; i want to see the
full history of each file that i listed.

+ If you need the (possibly intersecting) sets of revisions printed
> + separately, run the command twice, once for each file.

I'll do this if you really believe people want to ask your question
more than they want to ask mine.

--  
Eric Gillespie <*> epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day.  Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Scott Lamb <sl...@slamb.org>]

Eric Gillespie wrote:
> I'll do this if you really believe people want to ask your question
> more than they want to ask mine.

Are you advocating duplicating the behavior of "cvs log" 100%? To be
honest, I absolutely hate that command, as I hate digging through
redundant information to find what I want. I always thought it would be
more logical to see all distinct log entries in inverse chronological
order affecting the files/directories I select (default recursive '.')
and which files are affected by each one. I was very pleased to discover
that "svn log -v" does exactly that.

I think plenty of other also hate "cvs log". Karl's cvs2cl script and
other similar ones would not be so widely used if this were not so.
Subversion stores logs in a much saner way (normalized); it makes sense
to take advantage of it.

--
Scott Lamb


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[cm...@collab.net]

Karl Fogel <kf...@newton.ch.collab.net> writes:

> Eric Gillespie <ep...@pretzelnet.org> writes:
> > While i'm here, what does --strict do?  Is it just --dont-follow-copies
> > like that description sounds like?  If so, its description a few
> > lines later ("use strict semantics") is not very good.  What "strict
> > semantics" are is not obvious.
> 
> I think it's don't follow copies, yeah.  Mike?

Yep.  The descriptions for the options are not defined on a
per-subcommand basis.  The usage for `svn log' does say:

   By default, the resultant collection of log messages for a given
   path will include logs for all the revisions in which that path's
   node was modified, spanning copy history where such exists.  This
   can be disabled by using the --strict option.

but I guess "this can be disabled" leaves quite a bit of
interpretation wiggle room.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Karl Fogel <kf...@newton.ch.collab.net>]

Eric Gillespie <ep...@pretzelnet.org> writes:
> While i'm here, what does --strict do?  Is it just --dont-follow-copies
> like that description sounds like?  If so, its description a few
> lines later ("use strict semantics") is not very good.  What "strict
> semantics" are is not obvious.

I think it's don't follow copies, yeah.  Mike?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Karl Fogel <kf...@newton.ch.collab.net>]

Eric Gillespie <ep...@pretzelnet.org> writes:
> Maybe.  I suppose the "Changed paths" line is what you were talking
> about.  It doesn't look like what i want, but i suppose i'll give
> it a try.  Why is this information withheld without -v?  It's only
> an extra line, not verbose output i'd expect to be hidden behind
> -v.

It's N extra lines -- one line for each path affected by the commit,
plus the "Changed paths:" line itself.  That's a lot of vertical space
to eat by default.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Eric Gillespie <ep...@pretzelnet.org>]

Karl Fogel <kf...@newton.ch.collab.net> writes:

> Oh, if *that's* the problem, then there's no problem.
> 
>    $ svn log -v

Maybe.  I suppose the "Changed paths" line is what you were talking
about.  It doesn't look like what i want, but i suppose i'll give
it a try.  Why is this information withheld without -v?  It's only
an extra line, not verbose output i'd expect to be hidden behind
-v.

> The fix is not yet installed on the Subversion server, since we
> haven't upgraded our repository, but it will be soon.  If you're
> running your own repository, then it just depends, of course.

Yeah, it works great.

> Hmm, that's a problem.  If you have a patch for the help output, that
> would be great.

How about this?

    Display the log messages for local PATHs or PATHs at the URL.
    If URL is given by itself, then log messages are output for
    that specific path.  The log messages for each file are all
    collected, sorted, and output in order without regard to which
    PATH the log message came from.  The -v option will include a
    list of affected files for each log message..  By default, the
    resultant collection of log messages for a given path will
    include logs for all the revisions in which that path's node
    was modified, spanning copy history where such exists.  This
    can be disabled by using the --strict option.  Examples are:

While i'm here, what does --strict do?  Is it just --dont-follow-copies
like that description sounds like?  If so, its description a few
lines later ("use strict semantics") is not very good.  What "strict
semantics" are is not obvious.

--  
Eric Gillespie <*> epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day.  Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Karl Fogel <kf...@newton.ch.collab.net>]

Eric Gillespie <ep...@pretzelnet.org> writes:
> That may because of your project policy WRT writing log messages.
> We have never included filenames in log messages unless it is
> necessary because you're committing multiple files (doesn't happen
> very often, IME).  There just isn't any point in duplicating the
> information, because cvs can show it to you.  With svn, that isn't
> currently the case; we'd have to include the filename in the commit
> message just so we can deciper the current svn log output.

Oh, if *that's* the problem, then there's no problem.

   $ svn log -v

... which Mike Pilato has fixed (it was issue #690, and then #790).

The fix is not yet installed on the Subversion server, since we
haven't upgraded our repository, but it will be soon.  If you're
running your own repository, then it just depends, of course.

> Well, it isn't quite clear when you read the help output with the
> assumptions a cvs user has.

Hmm, that's a problem.  If you have a patch for the help output, that
would be great.

Thanks,
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Eric Gillespie <ep...@pretzelnet.org>]

Karl Fogel <kf...@newton.ch.collab.net> writes:

> I don't know which most people would prefer, if they had experience
> with both.  I know I've been finding the current behavior just as
> useful as the other behavior, and have never missed the other
> behavior.  But that's just one person.

That may because of your project policy WRT writing log messages.
We have never included filenames in log messages unless it is
necessary because you're committing multiple files (doesn't happen
very often, IME).  There just isn't any point in duplicating the
information, because cvs can show it to you.  With svn, that isn't
currently the case; we'd have to include the filename in the commit
message just so we can deciper the current svn log output.

> In any case, it shouldn't be in the issue tracker, it should be a
> discussion on the dev list.  Subversion was behaving as documented, so

Well, it isn't quite clear when you read the help output with the
assumptions a cvs user has.

--  
Eric Gillespie <*> epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day.  Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 802] Changed - No separation between files when svn log on multiple files

[Karl Fogel <kf...@newton.ch.collab.net>]

Eric Gillespie <ep...@pretzelnet.org> writes:
> But i don't think that's what people want; it doesn't sound
> particularly useful.  I think when people give multiple files to
> svn log, they want to see the history of each of those files.
>
> > + once -- that is, if both FILE_A and FILE_B changed in that revision,
> > + it won't be printed twice, only once.
> 
> I think it should be, but in separate sections; i want to see the
> full history of each file that i listed.
>
> + If you need the (possibly intersecting) sets of revisions printed
> > + separately, run the command twice, once for each file.
> 
> I'll do this if you really believe people want to ask your question
> more than they want to ask mine.

I don't know which most people would prefer, if they had experience
with both.  I know I've been finding the current behavior just as
useful as the other behavior, and have never missed the other
behavior.  But that's just one person.

In any case, it shouldn't be in the issue tracker, it should be a
discussion on the dev list.  Subversion was behaving as documented, so
no issue there.  (There will be an issue if we decide to change the
behavior, obviously :-) ).

I personally have zero desire to change this, being satisfied with the
current interface, so am not going to drive the thread.  It's all you,
baby...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org