You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2016/06/21 18:26:36 UTC
[kudu-CR] Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3424
Change subject: Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.
......................................................................
Added more to the documentation for botched installation. Users
should uninstall the dependencies and install them again after
cleaning the project.
Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
---
M docs/installation.adoc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/3424/1
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
[kudu-CR] Add additional documentation for bad installation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add additional documentation for bad installation
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/1919/
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add additional documentation for bad installation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add additional documentation for bad installation
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/1920/
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add additional documentation for bad installation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3424
to look at the new patch set (#4).
Change subject: Add additional documentation for bad installation
......................................................................
Add additional documentation for bad installation
Added more to the documentation for botched installation. Users
should uninstall the dependencies and install them again after
cleaning the project.
See:
https://github.com/anjuwong/kudu/blob/installation-doc/docs/installation.adoc#os-x
Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/3424/4
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add additional documentation for bad installation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Add additional documentation for bad installation
......................................................................
Add additional documentation for bad installation
Added more to the documentation for botched installation. Users
should uninstall the dependencies and install them again after
cleaning the project.
See:
https://github.com/anjuwong/kudu/blob/installation-doc/docs/installation.adoc#os-x
Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Reviewed-on: http://gerrit.cloudera.org:8080/3424
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add additional documentation for bad installation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add additional documentation for bad installation
......................................................................
Patch Set 2:
Since you're modifying an asciidoc file, could you generate rendered output too? The easiest way to do that is to fork the Kudu project on github, push this patch to your fork as some new branch, and provide a link to the modified file in the fork. This works because github automatically renders asciidoc files correctly.
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3424/1//COMMIT_MSG
Commit Message:
Line 7: Added more to the documentation for botched installation. Users
look at other patches. we usually have a short title and then a longer explanation (with a blank line in between).
A possible example would be:
Added information about how to workaround a botched thirdparty build
In some cases the thirdparty build might become stuck if the user didn't make sure the pre-requisites were met before starting the thirdparty build. This patch adds information on what should be done in that case: the user should clean the workspace and then try to re-build.
http://gerrit.cloudera.org:8080/#/c/3424/1/docs/installation.adoc
File docs/installation.adoc:
Line 561: $ brew uninstall autoconf automake cmake libtool pkg-config boost pstree
did you need to uninstall/reinstall?
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Add additional documentation for bad installation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add additional documentation for bad installation
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add additional documentation for bad installation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add additional documentation for bad installation
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/1915/
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1914/
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add additional documentation for bad installation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3424
to look at the new patch set (#2).
Change subject: Add additional documentation for bad installation
......................................................................
Add additional documentation for bad installation
Added more to the documentation for botched installation. Users
should uninstall the dependencies and install them again after
cleaning the project.
Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
---
M docs/installation.adoc
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/3424/2
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add additional documentation for bad installation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3424
to look at the new patch set (#3).
Change subject: Add additional documentation for bad installation
......................................................................
Add additional documentation for bad installation
Added more to the documentation for botched installation. Users
should uninstall the dependencies and install them again after
cleaning the project.
See:
https://github.com/anjuwong/kudu/blob/installation-doc/docs/installation.adoc
Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/3424/3
--
To view, visit http://gerrit.cloudera.org:8080/3424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I451549b8396d929dd53db629ff9ba5c9f87ca5a2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins