Re: cvs commit: apache-1.3/src/support apachectl

[Rodent of Unusual Size <co...@Apache.Org>]

martin@hyperreal.org wrote:
> 
>   Log:
>   Suppress errors of 'kill -0' when no server is running
> 
>   -     if kill -0 $PID; then
>   +     if kill -0 $PID 2>/dev/null; then

The problem with this is that it will conceal legitimate errors,
such as '-0' not being a valid combination (as I think was
discovered about six weeks ago on some system or other).

#ken    P-)}

Ken Coar                    <http://Web.Golux.Com/coar/>
Apache Group member         <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>

Re: cvs commit: apache-1.3/src/support apachectl

[Martin Kraemer <ma...@mch.sni.de>]

On Tue, Sep 08, 1998 at 05:14:15PM -0400, Rodent of Unusual Size wrote:
> >   Suppress errors of 'kill -0' when no server is running
> > 
> >   -     if kill -0 $PID; then
> >   +     if kill -0 $PID 2>/dev/null; then
> 
> The problem with this is that it will conceal legitimate errors,
> such as '-0' not being a valid combination (as I think was
> discovered about six weeks ago on some system or other).

OTOH this prevents us from questions about the error message that's
printed on a legimite "apachectl start".

Wasn't there a talk about adding unlink(ap_pid_fname) to
clean_parent_exit() some time ago?

Do you want me to roll back this change?

    Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request