You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/07/18 04:58:17 UTC
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3501:
Fix stop VM issue on basic zones
nvazquez commented on a change in pull request #3501: Fix stop VM issue on basic zones
URL: https://github.com/apache/cloudstack/pull/3501#discussion_r304734726
##########
File path: server/src/main/java/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java
##########
@@ -198,7 +198,7 @@ public boolean visit(final DhcpEntryRules dhcp) throws ResourceUnavailableExcept
final DeployDestination destination = dhcp.getDestination();
final boolean remove = dhcp.isRemove();
- if (router.getPodIdToDeployIn().longValue() == destination.getPod().getId()) {
+ if (destination != null && router.getPodIdToDeployIn().longValue() == destination.getPod().getId()) {
Review comment:
Thanks @anuragaw, added defensive checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services