[GitHub] [spark] MaxGekk commented on a change in pull request #31578: [SPARK-34455][SQL] Deprecate `spark.sql.legacy.replaceDatabricksSparkAvro.enabled`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #31578:
URL: https://github.com/apache/spark/pull/31578#discussion_r578148816



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3145,7 +3145,9 @@ object SQLConf {
       DeprecatedConfig(AVRO_REBASE_MODE_IN_WRITE.alternatives.head, "3.2",
         s"Use '${AVRO_REBASE_MODE_IN_WRITE.key}' instead."),
       DeprecatedConfig(AVRO_REBASE_MODE_IN_READ.alternatives.head, "3.2",
-        s"Use '${AVRO_REBASE_MODE_IN_READ.key}' instead.")
+        s"Use '${AVRO_REBASE_MODE_IN_READ.key}' instead."),
+      DeprecatedConfig(LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED.key, "3.2",
+        """Use `.format("avro")` in `DataFrameWriter` or `DataFrameReader` instead.""")

Review comment:
       The configs is about automatically mapping of `.format("com.databricks.spark.avro")` to `.format("avro")`, right? If we remove the config in the future, "com.databricks.spark.avro" will be not mapped to built in `avro`. So, in the guide, we recommend to change users code, and use the `avro` format directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org