You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/04 21:32:31 UTC
[GitHub] [druid] gianm opened a new pull request #9310: Remove EasyMock
dependency from CalciteTests.
gianm opened a new pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310
Useful because CalciteTests is used by other modules (e.g. druid-benchmarks)
and we don't want them to have to pull in EasyMock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on a change in pull request #9310: Remove
EasyMock dependency from CalciteTests.
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310#discussion_r375062378
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java
##########
@@ -129,20 +133,24 @@
import org.apache.druid.sql.calcite.view.ViewManager;
import org.apache.druid.timeline.DataSegment;
import org.apache.druid.timeline.partition.LinearShardSpec;
-import org.easymock.EasyMock;
Review comment:
Hmm, probably either modify FakeDruidNodeDiscoveryProvider to return actual servers (it's a simple thing to subclass, or restore EasyMock in druid-sql and find another way to solve the original problem (https://github.com/apache/druid/pull/9308#issuecomment-582128976) — a suppression or something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9310:
Remove EasyMock dependency from CalciteTests.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310#discussion_r375061118
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java
##########
@@ -129,20 +133,24 @@
import org.apache.druid.sql.calcite.view.ViewManager;
import org.apache.druid.timeline.DataSegment;
import org.apache.druid.timeline.partition.LinearShardSpec;
-import org.easymock.EasyMock;
Review comment:
Hmm, I've got an open PR that is using EasyMock heavily to allow for testing sql queries on system tables....
https://github.com/apache/druid/pull/6974/files#diff-ed8d85db2f346595b7faf34f45a78fd6R870
Any ideas on what we should do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9310: Remove EasyMock
dependency from CalciteTests.
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on a change in pull request #9310: Remove
EasyMock dependency from CalciteTests.
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310#discussion_r375062378
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java
##########
@@ -129,20 +133,24 @@
import org.apache.druid.sql.calcite.view.ViewManager;
import org.apache.druid.timeline.DataSegment;
import org.apache.druid.timeline.partition.LinearShardSpec;
-import org.easymock.EasyMock;
Review comment:
Hmm, probably either modify FakeDruidNodeDiscoveryProvider to return actual servers (it's a simple thing to subclass), or restore EasyMock in druid-sql and find another way to solve the original problem (https://github.com/apache/druid/pull/9308#issuecomment-582128976) — a suppression or something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9310:
Remove EasyMock dependency from CalciteTests.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310#discussion_r375064517
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java
##########
@@ -129,20 +133,24 @@
import org.apache.druid.sql.calcite.view.ViewManager;
import org.apache.druid.timeline.DataSegment;
import org.apache.druid.timeline.partition.LinearShardSpec;
-import org.easymock.EasyMock;
Review comment:
To do the former i would also need to implement `FakeDruidNodeDiscovery` too I think for the provider to provide to get the list of servers.. which i guess isn't that big a deal probably...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on a change in pull request #9310: Remove
EasyMock dependency from CalciteTests.
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310#discussion_r375062704
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java
##########
@@ -129,20 +133,24 @@
import org.apache.druid.sql.calcite.view.ViewManager;
import org.apache.druid.timeline.DataSegment;
import org.apache.druid.timeline.partition.LinearShardSpec;
-import org.easymock.EasyMock;
Review comment:
If you want to do the former, we can merge this and then you can update your PR; if you want to do the latter, I can change this patch to add a suppression. I'm ok either way so let me know what you think is best.
(But check out the thread on dev@druid about EasyMock first 🙂)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org