[jira] [Commented] (MAPREDUCE-5335) Rename Job Tracker terminology in ShuffleSchedulerImpl

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315971#comment-14315971 ] 

Hadoop QA commented on MAPREDUCE-5335:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12698044/MAPREDUCE-5335-1.patch
  against trunk revision a4ceea6.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5184//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5184//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5184//console

This message is automatically generated.

> Rename Job Tracker terminology in ShuffleSchedulerImpl
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-5335
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5335
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-5335-1.patch, MAPREDUCE-5335.patch
>
>
> {code:xml}
> 2013-06-17 17:27:30,134 INFO [fetcher#2] org.apache.hadoop.mapreduce.task.reduce.ShuffleScheduler: Reporting fetch failure for attempt_1371467533091_0005_m_000010_0 to jobtracker.
> {code}
> {code:title=ShuffleSchedulerImpl.java|borderStyle=solid}
>   // Notify the JobTracker
>   // after every read error, if 'reportReadErrorImmediately' is true or
>   // after every 'maxFetchFailuresBeforeReporting' failures
>   private void checkAndInformJobTracker(
>       int failures, TaskAttemptID mapId, boolean readError,
>       boolean connectExcpt) {
>     if (connectExcpt || (reportReadErrorImmediately && readError)
>         || ((failures % maxFetchFailuresBeforeReporting) == 0)) {
>       LOG.info("Reporting fetch failure for " + mapId + " to jobtracker.");
>       status.addFetchFailedMap((org.apache.hadoop.mapred.TaskAttemptID) mapId);
>     }
>   }
>  {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)