[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939759#comment-14939759 ] 

ASF GitHub Bot commented on STORM-1057:
---------------------------------------

Github user wangli1426 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/753#discussion_r40907742
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java ---
    @@ -72,7 +80,7 @@ public RateTracker(int validTimeWindowInMils, int numOfSlides, boolean simulate
          * @param count number of arrivals
          */
         public void notify(long count) {
    -        _histograms[_histograms.length-1]+=count;
    +        _histograms[_numOfSlides - 1] += count;
    --- End diff --
    
    @revans2 
    Thanks for your comment. Will you solve [STORM-1078] by yourself? I can solve this bug if you are too busy to do it.


> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
>                 Key: STORM-1057
>                 URL: https://issues.apache.org/jira/browse/STORM-1057
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Li Wang
>            Assignee: Li Wang
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance bottleneck of a topology. Displaying the throughputs of components and tasks on the web ui could greatly facilitate the user identifying the performance bottleneck and checking whether the the workload among components and tasks are balanced. 
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)