[GitHub] [trafficcontrol] ocket8888 commented on issue #3754: GET api/{version}/users/:userid/deliveryservices returns incorrect results

[GitBox <gi...@apache.org>]

ocket8888 commented on issue #3754: GET api/{version}/users/:userid/deliveryservices returns incorrect results
URL: https://github.com/apache/trafficcontrol/issues/3754#issuecomment-516014801
 
 
   I don't think this a bug. The docs for that endpoint say:
   
   > _"Retrieves all Delivery Services assigned to the user."_
   
   which is what it does - although those are filtered by tenancy. Changing that behavior would be a breaking change, although personally I don't have a problem with that. Just that it may need to be restricted to the 1.4 API.
   
   And for the record, I do think the behavior of the endpoint as-is are no longer useful, but using this endpoint to return Delivery Services may not be intuitive, since it has `user` and `userId` in the path. What if instead the `tenant` query parameter of a request to `/deliveryservice` was expanded to include sub-tenants? Or if that's undesirable - which I could see - maybe add a parameter `accessibleTo` to name a tenant and return all Delivery Services accessible to that tenant?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services