You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/31 00:11:44 UTC
[kudu-CR](branch-1.11.x) [docs] fix broken links reported by 'site tool proof'
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14594
to review the following change.
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
[docs] fix broken links reported by 'site_tool proof'
While preparing to update the contents of the project site for 1.11.0
release, I found that the 'site_tool proof' reports many broken links.
This patch fixes that, so 'site_tool proof' returns clean.
I also updated the installation.adoc, moving the information on API
documentaion into developing.adoc. By my understanding, that piece
doesn't belong to installation-related topics. I also updated the
JDK requirements to reflect the fact of dropping support of Java 7
in prior release (i.e. 1.10.0).
Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Reviewed-on: http://gerrit.cloudera.org:8080/14591
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9f01e7632d912b635caf8073a3e63fb8b8407b2a)
---
M docs/developing.adoc
M docs/hive_metastore.adoc
M docs/installation.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M docs/security.adoc
6 files changed, 46 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/14594/1
--
To view, visit http://gerrit.cloudera.org:8080/14594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.11.x) [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14594 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Oct 2019 00:12:29 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14594 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
[docs] fix broken links reported by 'site_tool proof'
While preparing to update the contents of the project site for 1.11.0
release, I found that the 'site_tool proof' reports many broken links.
This patch fixes that, so 'site_tool proof' returns clean.
I also updated the installation.adoc, moving the information on API
documentaion into developing.adoc. By my understanding, that piece
doesn't belong to installation-related topics. I also updated the
JDK requirements to reflect the fact of dropping support of Java 7
in prior release (i.e. 1.10.0).
Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Reviewed-on: http://gerrit.cloudera.org:8080/14591
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9f01e7632d912b635caf8073a3e63fb8b8407b2a)
Reviewed-on: http://gerrit.cloudera.org:8080/14594
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/developing.adoc
M docs/hive_metastore.adoc
M docs/installation.adoc
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
M docs/security.adoc
6 files changed, 46 insertions(+), 45 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14594
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [docs] fix broken links reported by 'site tool proof'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14594 )
Change subject: [docs] fix broken links reported by 'site_tool proof'
......................................................................
Patch Set 1: Code-Review+2
Got +2 for the original patch in the main branch from Grant. Carrying it over here.
--
To view, visit http://gerrit.cloudera.org:8080/14594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8e3a477dacf7dc304d138de7efedc1e6d93b65
Gerrit-Change-Number: 14594
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 31 Oct 2019 00:12:24 +0000
Gerrit-HasComments: No