You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/17 10:07:49 UTC
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r851733354
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SplitDynamicPrefixComposerFactory.java:
##########
@@ -0,0 +1,85 @@
+package org.eclipse.aether.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.repository.RemoteRepository;
+
+/**
+ * Split composer: splits to localPrefix (locally built and installed) and remotePrefix (cache). Cache is further
+ * split by release or snapshots.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( SplitDynamicPrefixComposerFactory.NAME )
+public final class SplitDynamicPrefixComposerFactory extends DynamicPrefixComposerFactorySupport
+{
+ public static final String NAME = "split";
+
+ @Override
+ protected DynamicPrefixComposer dpCreateComposer( RepositorySystemSession session, String localPrefix,
+ String remotePrefix, String releasePrefix, String snapshotPrefix )
+ {
+ return new SplitDynamicPrefixComposer( localPrefix, remotePrefix, releasePrefix, snapshotPrefix );
+ }
+
+ private static final class SplitDynamicPrefixComposer extends DynamicPrefixComposerSupport
+ {
+ private SplitDynamicPrefixComposer( String localPrefix,
+ String remotePrefix,
+ String releasePrefix,
+ String snapshotPrefix )
+ {
+ super( localPrefix, remotePrefix, releasePrefix, snapshotPrefix );
+ }
+
+ @Override
+ public String getPrefixForLocalArtifact( Artifact artifact )
+ {
+ return localPrefix;
Review Comment:
fixed
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SplitDynamicPrefixComposerFactory.java:
##########
@@ -0,0 +1,85 @@
+package org.eclipse.aether.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.repository.RemoteRepository;
+
+/**
+ * Split composer: splits to localPrefix (locally built and installed) and remotePrefix (cache). Cache is further
+ * split by release or snapshots.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named( SplitDynamicPrefixComposerFactory.NAME )
+public final class SplitDynamicPrefixComposerFactory extends DynamicPrefixComposerFactorySupport
+{
+ public static final String NAME = "split";
+
+ @Override
+ protected DynamicPrefixComposer dpCreateComposer( RepositorySystemSession session, String localPrefix,
+ String remotePrefix, String releasePrefix, String snapshotPrefix )
+ {
+ return new SplitDynamicPrefixComposer( localPrefix, remotePrefix, releasePrefix, snapshotPrefix );
+ }
+
+ private static final class SplitDynamicPrefixComposer extends DynamicPrefixComposerSupport
+ {
+ private SplitDynamicPrefixComposer( String localPrefix,
+ String remotePrefix,
+ String releasePrefix,
+ String snapshotPrefix )
+ {
+ super( localPrefix, remotePrefix, releasePrefix, snapshotPrefix );
+ }
+
+ @Override
+ public String getPrefixForLocalArtifact( Artifact artifact )
+ {
+ return localPrefix;
+ }
+
+ @Override
+ public String getPrefixForRemoteArtifact( Artifact artifact, RemoteRepository repository, String context )
+ {
+ return remotePrefix + "/"
+ + ( artifact.isSnapshot() ? snapshotPrefix : releasePrefix );
+ }
+
+ @Override
+ public String getPrefixForLocalMetadata( Metadata metadata )
+ {
+ return localPrefix;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org