You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2017/01/11 07:40:59 UTC

[GitHub] zeppelin pull request #1884: [ZEPPELIN-1936] Fix user impersonation setting ...

GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/1884

    [ZEPPELIN-1936] Fix user impersonation setting propagation 

    ### What is this PR for?
    This is to fix bug of creating interpreter with impersonation enabled
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - fix model
    
    ### What is the Jira issue?
    [ZEPPELIN-1936](https://issues.apache.org/jira/browse/ZEPPELIN-1936)
    
    ### How should this be tested?
    create new interpreter with "User Impersonation" enabled
    
    ### Screenshots (if appropriate)
    before:
    ![before_imp_setting](https://cloud.githubusercontent.com/assets/1642088/21839491/e187fa18-d78c-11e6-864d-755fc40f0096.gif)
    
    after:
    ![after_imp_setting](https://cloud.githubusercontent.com/assets/1642088/21839721/2756a7f0-d78e-11e6-9efd-4f3fd29df616.gif)
    
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix/new-interp-impersonation-setting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1884
    
----
commit d5f839396be6bec9adf74bc37db10971a4eac735
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-01-11T07:22:35Z

    fix model on interpreter-create

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1884: [ZEPPELIN-1936] Fix user impersonation setting propaga...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1884
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1884: [ZEPPELIN-1936] Fix user impersonation setting propaga...

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1884
  
    LGTM, merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1884: [ZEPPELIN-1936] Fix user impersonation setting propaga...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1884
  
    LGTM 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1884: [ZEPPELIN-1936] Fix user impersonation setting ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1884


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---