You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/01/30 23:47:38 UTC
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12320
to review the following change.
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
KUDU-2684: deduplicate master addrs on tservers
This patch deduplicates master addresses that get used to spin up
heartbeater threads. Previously, duplicate addresses meant sending
multiple tablet reports at a time during heartbeats.
This is addressed by having the TabletServer deduplicate the host-port
pairs and passing the deduplicated set to the Heartbeater. I considered
having the TabletServerOptions deduplicate the pairs up front by storing
a set, but that seemed like a wider-touching change, and is at odds with
how we handle user-provided options elsewhere.
Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/heartbeater.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/util/net/net_util.h
6 files changed, 72 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/12320/1
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@554
PS1, Line 554: The duplication should be considered
Nit: not really sure what this is trying to say.
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/tserver/tablet_server.cc
File src/kudu/tserver/tablet_server.cc:
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/tserver/tablet_server.cc@97
PS1, Line 97: std::vector<HostPort> addr_list;
Add a using.
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Jan 2019 00:16:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12320
to look at the new patch set (#2).
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
KUDU-2684: deduplicate master addrs on tservers
This patch deduplicates master addresses that get used to spin up
heartbeater threads. Previously, duplicate addresses meant sending
multiple tablet reports at a time during heartbeats.
This is addressed by having the TabletServer deduplicate the host-port
pairs and passing the deduplicated set to the Heartbeater. I considered
having the TabletServerOptions deduplicate the pairs up front by storing
a set, but that seemed like a wider-touching change, and is at odds with
how we handle user-provided options elsewhere.
Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/heartbeater.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/util/net/net_util.h
6 files changed, 74 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/12320/2
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
Patch Set 2: Verified+1
I filed KUDU-2686 for the failure; doesn't seem to be related.
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Jan 2019 02:14:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@554
PS1, Line 554: ERT_OK(mini_tserver->WaitStarted());
> Nit: not really sure what this is trying to say.
Done
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/tserver/tablet_server.cc
File src/kudu/tserver/tablet_server.cc:
http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/tserver/tablet_server.cc@97
PS1, Line 97: vector<HostPort> addr_list;
> Add a using.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Jan 2019 00:40:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Jan 2019 00:40:22 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
KUDU-2684: deduplicate master addrs on tservers
This patch deduplicates master addresses that get used to spin up
heartbeater threads. Previously, duplicate addresses meant sending
multiple tablet reports at a time during heartbeats.
This is addressed by having the TabletServer deduplicate the host-port
pairs and passing the deduplicated set to the Heartbeater. I considered
having the TabletServerOptions deduplicate the pairs up front by storing
a set, but that seemed like a wider-touching change, and is at odds with
how we handle user-provided options elsewhere.
Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Reviewed-on: http://gerrit.cloudera.org:8080/12320
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/heartbeater.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/util/net/net_util.h
6 files changed, 74 insertions(+), 28 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Andrew Wong: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2684: deduplicate master addrs on tservers
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Jan 2019 18:33:11 +0000
Gerrit-HasComments: No